You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2020/12/02 02:57:32 UTC
[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16807
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
......................................................................
IMPALA-10373: Run impala docker containers with uid/gid 1000
The convention in in linux is to that anything below 1000 is reserved
for system accounts, services, and other special accounts, and
regular user UIDs and GIDs stay above 1000. This will ensure that the
'impala' user created that runs the impala executable inside the
docker container gets assigned 1000 uid and gid.
Testing:
Manually tested by running the docker container and checking the user.
Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
---
M docker/impala_base/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/16807/1
--
To view, visit http://gerrit.cloudera.org:8080/16807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Gerrit-Change-Number: 16807
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 )
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Gerrit-Change-Number: 16807
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Dec 2020 00:59:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16807 )
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
......................................................................
IMPALA-10373: Run impala docker containers with uid/gid 1000
The convention in in linux is to that anything below 1000 is reserved
for system accounts, services, and other special accounts, and
regular user UIDs and GIDs stay above 1000. This will ensure that the
'impala' user created that runs the impala executable inside the
docker container gets assigned 1000 uid and gid.
Testing:
Manually tested by running the docker container and checking the user.
Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Reviewed-on: http://gerrit.cloudera.org:8080/16807
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docker/impala_base/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Andrew Sherman: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Gerrit-Change-Number: 16807
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 )
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7762/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Gerrit-Change-Number: 16807
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Dec 2020 03:19:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 )
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6723/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Gerrit-Change-Number: 16807
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:26:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 )
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/16807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51b846ca5fb2c55ac1707b9581cee18447467b41
Gerrit-Change-Number: 16807
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Dec 2020 17:25:46 +0000
Gerrit-HasComments: No