You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by northlander <gi...@git.apache.org> on 2015/10/11 19:39:02 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-252 adding Retry methods on...
GitHub user northlander opened a pull request:
https://github.com/apache/activemq-artemis/pull/193
ARTEMIS-252 adding Retry methods on JMX interface
A short-cut to move messages from DLQ to original queue via JMX operations retryMessage( messageId ) for a single message and retryMessages() for all messages.
Operations added to both JMS queue MBean and Core queue MBean.
https://issues.apache.org/jira/browse/ARTEMIS-252
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/northlander/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #193
----
commit 67ee840aba0e17eacdb5d4a9330901db98aeec9c
Author: Petter Nordlander <no...@gmail.com>
Date: 2015-10-10T14:58:04Z
ARTEMIS-252 added jmx operations to retry messages
commit 472945c5f5578608eee65ea0dcee9b21a4a2efa0
Author: Petter Nordlander <no...@gmail.com>
Date: 2015-10-11T17:34:23Z
ARTEMIS-252 Added support to retry messages via JMX on JMS Queue interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-252 adding Retry methods on...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/193#issuecomment-147512861
@northlander I'll run some tests and will merge this shortly... I have added the topic subscription case (which is actually a cool feature in top of AMQ5) and I have done some improvements as your method was performing N^2 scan (first scan and then doing scan over move(methodID)).
Look at my commit https://github.com/clebertsuconic/activemq-artemis/commit/fd62c24904a7d9c32e8fd907273ba957dc609f63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-252 adding Retry methods on...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-252 adding Retry methods on...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/193#issuecomment-147528398
@northlander that's really ok.. I appreciated the Pull Request... keep them coming :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-252 adding Retry methods on...
Posted by northlander <gi...@git.apache.org>.
Github user northlander commented on the pull request:
https://github.com/apache/activemq-artemis/pull/193#issuecomment-147527079
@clebertsuconic Great! Thanks a lot for the topic part as well.
I know it was a bit bad performing but I didn't really want to modify code outside of management package for this tiny feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-252 adding Retry methods on...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/193#issuecomment-147460503
Leave this one with me.. I will do it sometime today / tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---