[jira] [Commented] (HBASE-8389) HBASE-8354 DDoSes Namenode with lease recovery requests

["Varun Sharma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637610#comment-13637610 ] 

Varun Sharma commented on HBASE-8389:
-------------------------------------

Attached sample patch which works in our setup. We run with dfs.socket.timeout=3000 and dfs.socket.write.timeout=5000 - so recovery typically takes < 20 seconds since there is 1 WAL and we recover only 1 block.

If you closely observe the logs - the first useful recovery starts @49:05 since the first recovery chooses the dead datanode as the primary DN to do the recovery and first commit block is around 49:08 - hence, the recovery is finished within 3 seconds - this is the same as dfs.socket.timeout which is 3 seconds (the primary DN times out on the dead DN while trying to reconcile the replicas).

I believe if we do not pick stale node replicas (> 20 second heart beat) as primary DN(s) and when we choose a non stale replica as the primary DN, we do not reconcile blocks against the stale replica, we can get the lease recovery to finish under 1 second. Currently that is not the case. 

Varun
                
> HBASE-8354 DDoSes Namenode with lease recovery requests
> -------------------------------------------------------
>
>                 Key: HBASE-8389
>                 URL: https://issues.apache.org/jira/browse/HBASE-8389
>             Project: HBase
>          Issue Type: Improvement
>         Environment: We ran hbase 0.94.3 patched with 8354 and observed too many outstanding lease recoveries because of the short retry interval of 1 second between lease recoveries.
> The namenode gets into the following loop:
> 1) Receives lease recovery request and initiates recovery choosing a primary datanode every second
> 2) A lease recovery is successful and the namenode tries to commit the block under recovery as finalized - this takes < 10 seconds in our environment since we run with tight HDFS socket timeouts.
> 3) At step 2), there is a more recent recovery enqueued because of the aggressive retries. This causes the committed block to get preempted and we enter a vicious cycle
> So we do,  <initiate_recovery> --> <commit_block> --> <commit_preempted_by_another_recovery>
> This loop is paused after 300 seconds which is the "hbase.lease.recovery.timeout". Hence the MTTR we are observing is 5 minutes which is terrible. Our ZK session timeout is 30 seconds and HDFS stale node detection timeout is 20 seconds.
> Note that before the patch, we do not call recoverLease so aggressively - also it seems that the HDFS namenode is pretty dumb in that it keeps initiating new recoveries for every call. Before the patch, we call recoverLease, assume that the block was recovered, try to get the file, it has zero length since its under recovery, we fail the task and retry until we get a non zero length. So things just work.
> Fixes:
> 1) Expecting recovery to occur within 1 second is too aggressive. We need to have a more generous timeout. The timeout needs to be configurable since typically, the recovery takes as much time as the DFS timeouts. The primary datanode doing the recovery tries to reconcile the blocks and hits the timeouts when it tries to contact the dead node. So the recovery is as fast as the HDFS timeouts.
> 2) We have another issue I report in HDFS 4721. The Namenode chooses the stale datanode to perform the recovery (since its still alive). Hence the first recovery request is bound to fail. So if we want a tight MTTR, we either need something like HDFS 4721 or we need something like this
>   recoverLease(...)
>   sleep(1000)
>   recoverLease(...)
>   sleep(configuredTimeout)
>   recoverLease(...)
>   sleep(configuredTimeout)
> Where configuredTimeout should be large enough to let the recovery happen but the first timeout is short so that we get past the moot recovery in step #1.
>  
>            Reporter: Varun Sharma
>            Assignee: Varun Sharma
>             Fix For: 0.94.8
>
>         Attachments: nn1.log, nn.log, sample.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira