You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "Jan Bernhardt (JIRA)" <ji...@apache.org> on 2012/09/28 17:27:07 UTC
[jira] [Created] (SYNCOPE-212) Provide Validation Error message to
user
Jan Bernhardt created SYNCOPE-212:
-------------------------------------
Summary: Provide Validation Error message to user
Key: SYNCOPE-212
URL: https://issues.apache.org/jira/browse/SYNCOPE-212
Project: Syncope
Issue Type: Improvement
Components: console, core
Affects Versions: 1.0.1-incubating
Reporter: Jan Bernhardt
If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains an Error String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SYNCOPE-212) Provide Validation Error message to
user
Posted by "Jan Bernhardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Bernhardt updated SYNCOPE-212:
----------------------------------
Description:
If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
was:
If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains an Error String. By doing so a user could get notified why his value is invalid and how a good example would look like!
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SYNCOPE-212) Provide Validation Error message to
user
Posted by "Francesco Chicchiriccò (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francesco Chicchiriccò updated SYNCOPE-212:
-------------------------------------------
Fix Version/s: 1.1.0-incubating
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Fix For: 1.1.0-incubating
>
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SYNCOPE-212) Provide Validation Error message to
user
Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm O hEigeartaigh updated SYNCOPE-212:
----------------------------------------
Attachment: syncope-212.patch
Please see the attached patch for a potential solution.
Essentially it allows the InvalidAttrValueException to take a String error message, and uses this instead in each of the default Validators.
The resulting error message displayed for the EmailAddressValidator looks something like:
Error:{[InvalidValues [email: rrgiknsg - "rrgiknsg" is not a valid email address]]}
It also fixes a trivial bug in the SyncopeClientCompositeErrorException which always appends a comma to the error message.
Colm.
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Assignee: Colm O hEigeartaigh
> Fix For: 1.1.0-incubating
>
> Attachments: syncope-212.patch
>
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SYNCOPE-212) Provide Validation Error message to
user
Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm O hEigeartaigh resolved SYNCOPE-212.
-----------------------------------------
Resolution: Fixed
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Assignee: Colm O hEigeartaigh
> Fix For: 1.1.0-incubating
>
> Attachments: syncope-212.patch
>
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-212) Provide Validation Error message
to user
Posted by "Francesco Chicchiriccò (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482325#comment-13482325 ]
Francesco Chicchiriccò commented on SYNCOPE-212:
------------------------------------------------
Colm, your patch looks very fine!
+1 for me
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Assignee: Colm O hEigeartaigh
> Fix For: 1.1.0-incubating
>
> Attachments: syncope-212.patch
>
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-212) Provide Validation Error message
to user
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482403#comment-13482403 ]
Hudson commented on SYNCOPE-212:
--------------------------------
Integrated in Syncope-linux #308 (See [https://builds.apache.org/job/Syncope-linux/308/])
[SYNCOPE-212] - Provide Validation Error message to user (Revision 1401308)
Result = SUCCESS
coheigea :
Files :
* /incubator/syncope/trunk/client/src/main/java/org/apache/syncope/client/validation/SyncopeClientCompositeErrorException.java
* /incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/attrvalue/AlwaysTrueValidator.java
* /incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/attrvalue/BasicValidator.java
* /incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/attrvalue/EmailAddressValidator.java
* /incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/persistence/validation/attrvalue/InvalidAttrValueException.java
* /incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/rest/data/AbstractAttributableDataBinder.java
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Assignee: Colm O hEigeartaigh
> Fix For: 1.1.0-incubating
>
> Attachments: syncope-212.patch
>
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SYNCOPE-212) Provide Validation Error message to
user
Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm O hEigeartaigh reassigned SYNCOPE-212:
-------------------------------------------
Assignee: Colm O hEigeartaigh
> Provide Validation Error message to user
> ----------------------------------------
>
> Key: SYNCOPE-212
> URL: https://issues.apache.org/jira/browse/SYNCOPE-212
> Project: Syncope
> Issue Type: Improvement
> Components: console, core
> Affects Versions: 1.0.1-incubating
> Reporter: Jan Bernhardt
> Assignee: Colm O hEigeartaigh
> Fix For: 1.1.0-incubating
>
>
> If values are entered into a field that uses a validator, you will only get a notification that your validation failed for a specific attribute. But a user will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException should also provide a method that contains a message String. By doing so a user could get notified why his value is invalid and how a good example would look like!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira