You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/21 20:29:59 UTC
[GitHub] [airflow] o-nikolas opened a new pull request #19141: Update virtualenv guide to use correct constraints file
o-nikolas opened a new pull request #19141:
URL: https://github.com/apache/airflow/pull/19141
The constraints file that was used in the example code snippets is a constraints file for released versions (e.g.: airflow/constraints-main/constraints-3.6.txt). Which was leading to long dependency resolution times as well as dependency version conflicts when using the latest source from main. The correct constraints to use in this case is for example: airflow/constraints-main/constraints-source-providers-3.6.txt (docs explaining the differences for each type of constraints file can be [found here](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pinned-constraint-files)).
Note that constraints-source-providers is what is used by breeze if you use it to setup your local virtual env (as [seen here](https://github.com/apache/airflow/blob/e6fcf7776a298cff741d8a55f0990ea796fd0540/breeze#L262)). So this is really bringing the manual steps inline with this.
Further discussion can be found in the Slack thread where this was discussed: https://apache-airflow.slack.com/archives/CQ9QHSFQX/p1634839186006900?thread_ts=1634668910.074400&cid=CQ9QHSFQX
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19141: Update virtualenv guide to use correct constraints file
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19141:
URL: https://github.com/apache/airflow/pull/19141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19141: Update virtualenv guide to use correct constraints file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19141:
URL: https://github.com/apache/airflow/pull/19141#issuecomment-949033046
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org