You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/05/29 03:00:30 UTC
Review Request 21999: Predicates don't work on fields with float values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar and Tom Beerbower.
Bugs: AMBARI-5922
https://issues.apache.org/jira/browse/AMBARI-5922
Repository: ambari
Description
-------
API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
Currently the Greater than predicate will fail for values in between 0.0 and 1.0
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
Diff: https://reviews.apache.org/r/21999/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/#review44229
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On May 29, 2014, 1:20 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21999/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 1:20 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
>
>
> Bugs: AMBARI-5922
> https://issues.apache.org/jira/browse/AMBARI-5922
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
>
> Currently the Greater than predicate will fail for values in between 0.0 and 1.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
> ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
>
> Diff: https://reviews.apache.org/r/21999/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 207 tests in 0.662s
>
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On May 28, 2014, 10:08 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java, line 84
> > <https://reviews.apache.org/r/21999/diff/1/?file=598197#file598197line84>
> >
> > Why cast the result of compareTo(...) to a double when compareValueTo can use the integer value?
Ah, never mind; the import didn't work correctly in Eclipse and I missed a parens.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/#review44220
-----------------------------------------------------------
On May 28, 2014, 9:20 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21999/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:20 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
>
>
> Bugs: AMBARI-5922
> https://issues.apache.org/jira/browse/AMBARI-5922
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
>
> Currently the Greater than predicate will fail for values in between 0.0 and 1.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
> ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
>
> Diff: https://reviews.apache.org/r/21999/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 207 tests in 0.662s
>
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/#review44220
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java
<https://reviews.apache.org/r/21999/#comment78560>
Why cast the result of compareTo(...) to a double when compareValueTo can use the integer value?
- Jonathan Hurley
On May 28, 2014, 9:20 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21999/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:20 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
>
>
> Bugs: AMBARI-5922
> https://issues.apache.org/jira/browse/AMBARI-5922
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
>
> Currently the Greater than predicate will fail for values in between 0.0 and 1.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
> ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
>
> Diff: https://reviews.apache.org/r/21999/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 207 tests in 0.662s
>
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/#review44223
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On May 28, 2014, 9:20 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21999/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:20 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
>
>
> Bugs: AMBARI-5922
> https://issues.apache.org/jira/browse/AMBARI-5922
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
>
> Currently the Greater than predicate will fail for values in between 0.0 and 1.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
> ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
>
> Diff: https://reviews.apache.org/r/21999/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 207 tests in 0.662s
>
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/#review44219
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On May 29, 2014, 1:20 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21999/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 1:20 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
>
>
> Bugs: AMBARI-5922
> https://issues.apache.org/jira/browse/AMBARI-5922
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
>
> Currently the Greater than predicate will fail for values in between 0.0 and 1.0
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
> ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
>
> Diff: https://reviews.apache.org/r/21999/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 207 tests in 0.662s
>
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/
-----------------------------------------------------------
(Updated May 29, 2014, 1:20 a.m.)
Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Tom Beerbower.
Bugs: AMBARI-5922
https://issues.apache.org/jira/browse/AMBARI-5922
Repository: ambari
Description
-------
API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
Currently the Greater than predicate will fail for values in between 0.0 and 1.0
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
Diff: https://reviews.apache.org/r/21999/diff/
Testing
-------
----------------------------------------------------------------------
Ran 207 tests in 0.662s
OK
----------------------------------------------------------------------
Total run:560
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
Re: Review Request 21999: Predicates don't work on fields with float values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21999/
-----------------------------------------------------------
(Updated May 29, 2014, 1:18 a.m.)
Review request for Ambari, Mahadev Konar and Tom Beerbower.
Bugs: AMBARI-5922
https://issues.apache.org/jira/browse/AMBARI-5922
Repository: ambari
Description
-------
API should be able to process filter with predicates(<,>,=) for fields with float values; For example field: metrics/load/load_one.
Currently the Greater than predicate will fail for values in between 0.0 and 1.0
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java e8102d6
ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/GreaterPredicateTest.java af79eff
Diff: https://reviews.apache.org/r/21999/diff/
Testing (updated)
-------
----------------------------------------------------------------------
Ran 207 tests in 0.662s
OK
----------------------------------------------------------------------
Total run:560
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle