You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/28 05:55:23 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3955: [ZEPPELIN-5109]. Support knox in zeppelin-client

zjffdu opened a new pull request #3955:
URL: https://github.com/apache/zeppelin/pull/3955


   ### What is this PR for?
   
   This PR add support of knox in zeppelin-client. I tested it in a real environment. What user need to provide is the knos sso url
   
   ### What type of PR is it?
   [ Feature ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5109
   
   ### How should this be tested?
   * CI Pass.
   
   Sample code
   ```
       ClientConfig clientConfig = new ClientConfig("https://knox.c-9181957fabf52f7e.cn-hangzhou.databricks.aliyuncs.com:8443/gateway/cluster-topo/zeppelin",
               1000, "https://knox.c-9181957fabf52f7e.cn-hangzhou.databricks.aliyuncs.com:8443/gateway/knoxsso/api/v1/websso");
       ZeppelinClient zeppelinClient = new ZeppelinClient(clientConfig);
       zeppelinClient.login("zongze_ram", "1234qwer");
       String version = zeppelinClient.getVersion();
       System.out.println(version);
   ```
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3955: [ZEPPELIN-5109]. Support knox in zeppelin-client

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3955:
URL: https://github.com/apache/zeppelin/pull/3955#issuecomment-720542630


   @Reamer gson upgrade is necessary to support knox. Let me create a PR for gson first. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3955: [ZEPPELIN-5109]. Support knox in zeppelin-client

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3955:
URL: https://github.com/apache/zeppelin/pull/3955#issuecomment-720445534


   Maybe it makes sense to split the PR into GSON update and knox support for Zeppelin client.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3955: [ZEPPELIN-5109]. Support knox in zeppelin-client

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3955:
URL: https://github.com/apache/zeppelin/pull/3955


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3955: [ZEPPELIN-5109]. Support knox in zeppelin-client

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3955:
URL: https://github.com/apache/zeppelin/pull/3955#issuecomment-721218164


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org