[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1369: feat: support plugin_metadata of apisix

[GitBox <gi...@apache.org>]

AlinsRan commented on code in PR #1369:
URL: https://github.com/apache/apisix-ingress-controller/pull/1369#discussion_r1008982953


##########
pkg/apisix/apisix.go:
##########
@@ -152,6 +154,14 @@ type PluginConfig interface {
 	Update(context.Context, *v1.PluginConfig) (*v1.PluginConfig, error)
 }
 
+type PluginMetadata interface {
+	Get(context.Context, string) (*v1.PluginMetadata, error)
+	List(context.Context) ([]*v1.PluginMetadata, error)
+	Create(context.Context, *v1.PluginMetadata) (*v1.PluginMetadata, error)
+	Delete(context.Context, *v1.PluginMetadata) error
+	Update(context.Context, *v1.PluginMetadata) (*v1.PluginMetadata, error)
+}

Review Comment:
   Yeah, but get has two interfaces
   * plugin_name plugin_name: `/apisix/admin/plugin_metadata/{plugin_name}`
   * All configurations: `/apisix/admin/plugin_metadata`
   
   In fact, the http `PUT' method is used by create and update in all API (consumer/route...) interfaces.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org