You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2017/02/13 22:37:41 UTC
[jira] [Comment Edited] (HBASE-9702) Change unittests that use
"table" or "testtable" to use method names.
[ https://issues.apache.org/jira/browse/HBASE-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864568#comment-15864568 ]
Appy edited comment on HBASE-9702 at 2/13/17 10:37 PM:
-------------------------------------------------------
Wow. Great work [~Jan Hentschel]!
Give this patch 'Cleanup of the year' award (if there is one).
was (Author: appy):
Wow. Great work [~Jan Hentschel]!
> Change unittests that use "table" or "testtable" to use method names.
> ---------------------------------------------------------------------
>
> Key: HBASE-9702
> URL: https://issues.apache.org/jira/browse/HBASE-9702
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Jonathan Hsieh
> Assignee: Jan Hentschel
> Fix For: 2.0.0
>
> Attachments: HBASE-9702.master.001.patch, HBASE-9702.master.002.patch
>
>
> While working on HBASE-9686, many tests left files that indicated the method they had come from but several drop data in "table" or "testtable" tables. Naming them this way makes it hard to track which tests these came from. We should make all test use
> @Rule TestName name = new TestName();
> ...
> TableName t = TableName.valueOf(name.getMethodName());
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)