You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 10:48:29 UTC
[GitHub] [arrow] pitrou opened a new pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
pitrou opened a new pull request #8879:
URL: https://github.com/apache/arrow/pull/8879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8879:
URL: https://github.com/apache/arrow/pull/8879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824073798
Should be the MinGW32 rounding issue we met with many times before.
Guess PCG generator produces different random numbers than std::default_random_engine. So this issue is always there, just not revealed by previous test data.
I think we can disable the random test for MinGW32. ASSERT_DOUBLE_EQ expects at most 4ULP diff, it's almost there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-741692668
https://issues.apache.org/jira/browse/ARROW-10797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824516090
CentOS error may be caused by gcc-4.8 build failure from earlier pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824093360
Ok, I added a skip on MinGW32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824484122
Revision: c62dc304163a68844e76217da6f5ca4555da34bb
Submitted crossbow builds: [ursacomputing/crossbow @ actions-341](https://github.com/ursacomputing/crossbow/branches/all?query=actions-341)
|Task|Status|
|----|------|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-centos-7-amd64)|
|centos-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-centos-8-amd64)|
|centos-8-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-clean)|
|conda-linux-gcc-py36-arm64|[](https://cloud.drone.io/ursacomputing/crossbow)|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-arm64|[](https://cloud.drone.io/ursacomputing/crossbow)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-arm64|[](https://cloud.drone.io/ursacomputing/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py38-cuda)|
|conda-linux-gcc-py39-arm64|[](https://cloud.drone.io/ursacomputing/crossbow)|
|conda-linux-gcc-py39-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py39-cpu)|
|conda-linux-gcc-py39-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-linux-gcc-py39-cuda)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-win-vs2017-py37-r40)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-win-vs2017-py38)|
|conda-win-vs2017-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-conda-win-vs2017-py39)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-example-cpp-minimal-build-static-system-dependency)|
|gandiva-jar-osx|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-gandiva-jar-osx)|
|gandiva-jar-ubuntu|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-gandiva-jar-ubuntu)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-homebrew-r-autobrew)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-python-sdist)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-cpp-valgrind)|
|test-conda-python-3.6|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.6)|
|test-conda-python-3.6-pandas-0.23|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.6-pandas-0.23)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7)|
|test-conda-python-3.7-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-dask-latest)|
|test-conda-python-3.7-hdfs-3.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-hdfs-3.2)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-pandas-master)|
|test-conda-python-3.7-spark-branch-3.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-spark-branch-3.0)|
|test-conda-python-3.7-turbodbc-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-turbodbc-latest)|
|test-conda-python-3.7-turbodbc-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.7-turbodbc-master)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8)|
|test-conda-python-3.8-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8-dask-master)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-jpype|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8-jpype)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.8-spark-master)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-conda-python-3.9)|
|test-debian-10-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-debian-10-cpp)|
|test-debian-10-go-1.15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-debian-10-go-1.15)|
|test-debian-10-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-debian-10-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-fedora-33-python-3)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-r-devdocs)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-r-linux-as-cran)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-minimal-build)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-r-version-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-r-version-compatibility)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-r-versions)|
|test-r-without-arrow|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-r-without-arrow)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-ubuntu-18.04-python-3)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-341-azure-test-ubuntu-20.10-docs)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-c-glib)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-groovy-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-ubuntu-groovy-amd64)|
|ubuntu-groovy-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-osx-high-sierra-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-high-sierra-cp36)|
|wheel-osx-high-sierra-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-high-sierra-cp37)|
|wheel-osx-high-sierra-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-high-sierra-cp38)|
|wheel-osx-high-sierra-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-high-sierra-cp39)|
|wheel-osx-mavericks-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-mavericks-cp36)|
|wheel-osx-mavericks-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-mavericks-cp37)|
|wheel-osx-mavericks-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-mavericks-cp38)|
|wheel-osx-mavericks-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-osx-mavericks-cp39)|
|wheel-windows-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-windows-cp36)|
|wheel-windows-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-windows-cp37)|
|wheel-windows-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-windows-cp38)|
|wheel-windows-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-341-github-wheel-windows-cp39)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824048390
This exposes a small precision issue in the variance kernel tests in MinGW32 on 32-bit floats (because of rounding issues perhaps?):
https://github.com/pitrou/arrow/runs/2400347814?check_suite_focus=true#step:10:831
According to Numpy, the two float64 values differ by 5 ULPs:
```python
>>> a
1011966660.249961
>>> b
1011966660.2499604
>>> np.testing.assert_array_max_ulp(a, b)
Traceback (most recent call last):
File "<ipython-input-15-48fada135e2b>", line 1, in <module>
np.testing.assert_array_max_ulp(a, b)
File "/home/antoine/miniconda3/envs/pyarrow/lib/python3.7/site-packages/numpy/testing/_private/utils.py", line 1643, in assert_array_max_ulp
(maxulp, np.max(ret)))
AssertionError: Arrays are not almost equal up to 1 ULP (max difference is 5 ULP)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824483649
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org