svn commit: r479763 - in /mina/sandbox/mheath/aioj/trunk: src/main/c/org_apache_aio.cpp src/test/java/AIOTest.java todo.txt

[mh...@apache.org]

Author: mheath
Date: Mon Nov 27 13:02:40 2006
New Revision: 479763

URL: http://svn.apache.org/viewvc?view=rev&rev=479763
Log:
Consolodated completion handlers

Modified:
    mina/sandbox/mheath/aioj/trunk/src/main/c/org_apache_aio.cpp
    mina/sandbox/mheath/aioj/trunk/src/test/java/AIOTest.java
    mina/sandbox/mheath/aioj/trunk/todo.txt

Modified: mina/sandbox/mheath/aioj/trunk/src/main/c/org_apache_aio.cpp
URL: http://svn.apache.org/viewvc/mina/sandbox/mheath/aioj/trunk/src/main/c/org_apache_aio.cpp?view=diff&rev=479763&r1=479762&r2=479763
==============================================================================
--- mina/sandbox/mheath/aioj/trunk/src/main/c/org_apache_aio.cpp (original)
+++ mina/sandbox/mheath/aioj/trunk/src/main/c/org_apache_aio.cpp Mon Nov 27 13:02:40 2006
@@ -278,7 +278,6 @@
 }
 
 // --- Completion handlers ----------------------------------------------------------------
-// TODO: Consolodate completion handlers
 enum operation_mode {READ, WRITE};
 
 void aio_read_write_completion_handler(sigval_t sigval, operation_mode mode, char *jvmAttachErrorMessage, char *failureMessage)
@@ -339,5 +338,5 @@
 {
 	LOG_DEBUG("In write completion handler\n")
 
-	aio_read_write_completion_handler(sigval, READ, "Failed to attach JVM to AIO write thread\n", "Could not complete write request");
+	aio_read_write_completion_handler(sigval, WRITE, "Failed to attach JVM to AIO write thread\n", "Could not complete write request");
 }

Modified: mina/sandbox/mheath/aioj/trunk/src/test/java/AIOTest.java
URL: http://svn.apache.org/viewvc/mina/sandbox/mheath/aioj/trunk/src/test/java/AIOTest.java?view=diff&rev=479763&r1=479762&r2=479763
==============================================================================
--- mina/sandbox/mheath/aioj/trunk/src/test/java/AIOTest.java (original)
+++ mina/sandbox/mheath/aioj/trunk/src/test/java/AIOTest.java Mon Nov 27 13:02:40 2006
@@ -34,6 +34,7 @@
 		buffer.flip();
 		System.out.println("Position: " + buffer.position());
 		future = achannel.write(buffer, 0);
+		System.out.println("Position: " + buffer.position());
 		future.join();
 		System.out.println("Position: " + buffer.position());
 	}

Modified: mina/sandbox/mheath/aioj/trunk/todo.txt
URL: http://svn.apache.org/viewvc/mina/sandbox/mheath/aioj/trunk/todo.txt?view=diff&rev=479763&r1=479762&r2=479763
==============================================================================
--- mina/sandbox/mheath/aioj/trunk/todo.txt (original)
+++ mina/sandbox/mheath/aioj/trunk/todo.txt Mon Nov 27 13:02:40 2006
@@ -1,7 +1,7 @@
 - Add support for heap buffers
 - Throw IO Exceptions when aio calls return an error
 - Figure out batch requests
-- Add support for timeouts and error handling
+- Add support for timeouts
 - Add support for receiving file modification events
 - Make sure we're checking for errors on all JNI method calls
 
@@ -9,4 +9,5 @@
 - Make sure the AsynchronousFileChannel can be unloaded without holding onto native references
 - Test for memory leaks
 - Do performance tests
-- Write unit tests
\ No newline at end of file
+- Write unit tests
+- Determine if doing AttachCurrentThread or AttachCurrentThreadAsDaemon is faster in callback
\ No newline at end of file