You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2010/06/06 22:04:53 UTC
[jira] Created: (PIG-1441) New test targets: unit and smoke
New test targets: unit and smoke
--------------------------------
Key: PIG-1441
URL: https://issues.apache.org/jira/browse/PIG-1441
Project: Pig
Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich
Fix For: 0.8.0
As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1441) New test targets: unit and smoke
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876913#action_12876913 ]
Daniel Dai commented on PIG-1441:
---------------------------------
+1
> New test targets: unit and smoke
> --------------------------------
>
> Key: PIG-1441
> URL: https://issues.apache.org/jira/browse/PIG-1441
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.8.0
>
> Attachments: PIG-1441.patch, PIG-1441_2.patch
>
>
> As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
> unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
> smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
> I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1441) New test targets: unit and smoke
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876912#action_12876912 ]
Olga Natkovich commented on PIG-1441:
-------------------------------------
I updated the patch to include some join tests to the smoke for better coverage. I pulled a couple of tests from replicated and skew join as most commonly used. Note that I did not remove the tests from the original file so that we have good coverage when we test particular feature.
The tests now run in 23 minutes which gives us opportunity to add more in the future.
Please, review the patch. I would really like to commit it tomorrow. Thanks.
> New test targets: unit and smoke
> --------------------------------
>
> Key: PIG-1441
> URL: https://issues.apache.org/jira/browse/PIG-1441
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.8.0
>
> Attachments: PIG-1441.patch, PIG-1441_2.patch
>
>
> As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
> unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
> smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
> I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1441) New test targets: unit and smoke
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1441:
--------------------------------
Attachment: PIG-1441_2.patch
> New test targets: unit and smoke
> --------------------------------
>
> Key: PIG-1441
> URL: https://issues.apache.org/jira/browse/PIG-1441
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.8.0
>
> Attachments: PIG-1441.patch, PIG-1441_2.patch
>
>
> As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
> unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
> smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
> I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1441) New test targets: unit and smoke
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876537#action_12876537 ]
Olga Natkovich commented on PIG-1441:
-------------------------------------
I uploaded the patch.
Unit test target runs in about 35 minutes and executes all non e2e tests.
Smoke test target runs for 15 minutes so we can add more. So far, I have
- simple script (load + store)
- fairly complex script
- multiquery (in local mode because MR mode one takes 45 minutes). Ths also tests local mode so I think it is a good combination
- streaming
Please, suggest if we should add any other e2e tests.
Also, please, review the patch. It does not need to go through patch test since no code is modified.
> New test targets: unit and smoke
> --------------------------------
>
> Key: PIG-1441
> URL: https://issues.apache.org/jira/browse/PIG-1441
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.8.0
>
> Attachments: PIG-1441.patch
>
>
> As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
> unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
> smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
> I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-1441) New test targets: unit and smoke
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich resolved PIG-1441.
---------------------------------
Resolution: Fixed
patch committed to trunk and 0.6 and 0.7 branches. Thanks Daniel for review.
> New test targets: unit and smoke
> --------------------------------
>
> Key: PIG-1441
> URL: https://issues.apache.org/jira/browse/PIG-1441
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.8.0
>
> Attachments: PIG-1441.patch, PIG-1441_2.patch
>
>
> As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
> unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
> smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
> I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1441) New test targets: unit and smoke
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1441:
--------------------------------
Attachment: PIG-1441.patch
> New test targets: unit and smoke
> --------------------------------
>
> Key: PIG-1441
> URL: https://issues.apache.org/jira/browse/PIG-1441
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.8.0
>
> Attachments: PIG-1441.patch
>
>
> As we get more and more tests, adding more structure would help us to minimize time spent on testing. Here are 2 new targets I propose we add. (Hadoop has the same targets for the same purposes).
> unit - to run all true unit tests (those that trully testing apis and internal functionality and not running e2e tests through junit. This test should run relatively quick 10-15 minutes and if we are good at adding unit tests will give good covergae.
> smoke - this would be a set of a few e2e tests that provide good overall coverage within about 30 minutes.
> I would say that for simple patche, we would still require only commit tests while for more involved patches, the developers should run both unit and smoke before submitting the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.