You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by kjduling <gi...@git.apache.org> on 2016/06/30 22:10:38 UTC
[GitHub] incubator-geode pull request #183: GEODE-1615: gfsh unable to destroy region...
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/183
GEODE-1615: gfsh unable to destroy region that has an hyphen in its name
Added a test for whether or not the region contains a hyphen in the name. If it does, it is necessary to wrap the region name within quotes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit 80af962ef2f7eee4053804a20a28f41b46fb3192
Author: Kevin J. Duling <kd...@pivotal.io>
Date: 2016-06-30T22:07:22Z
GEODE-1615: gfsh unable to destroy region that has an hyphen in its name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...
Posted by kjduling <gi...@git.apache.org>.
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/183
Closing this. The test worked the first time, but subsequent runs consistently fail. I'll start a fresh pull request once I resolve it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...
Posted by kjduling <gi...@git.apache.org>.
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/183
I'm doing the test in a separate checkin once I have a final decision on what characters are valid. Right now, it appears only alphanumeric, an underscore, and a hyphen are the only valid characters allowed. Yet we can create regions with all sorts of characters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/183
For now, add at least a test that would cover deleting a region that has "-" and "_" in it. Later, you can expand your tests that would have all sorts of allowed characters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #183: GEODE-1615: gfsh unable to destroy region...
Posted by kjduling <gi...@git.apache.org>.
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/183
the fix looks good. Where is the test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---