You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Lucas Brutschy <lb...@confluent.io.INVALID> on 2023/01/02 08:18:51 UTC
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Thanks for the KIP! Seems like a useful thing to have. +1 (non-binding)
On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro> wrote:
>
> I agree that it seems straightforward. +1 (non-binding)
>
> On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > Hi Roman,
> >
> > Thanks for the KIP! I'm +1 (binding)
> >
> > Cheers,
> >
> > Chris
> >
> > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <ro...@gmail.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > Thank you for the feedback so far.
> > > The KIP is rather straightforward and I'd like to start a vote on it.
> > > Please have a look at the KIP:
> > > https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > >
> > > Thanks,
> > > Roman
> > >
> >
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Roman Schmitz <ro...@gmail.com>.
Hi Chris,
That's a good point. Renamed it to 'allowlist.pattern'.
Cheers,
Roman
Am Mo., 20. März 2023 um 22:41 Uhr schrieb Chris Egerton
<ch...@aiven.io.invalid>:
> Hi Roman,
>
> Thanks for the update. I wonder if the name is a bit unclear? Maybe
> something like "allowlist.pattern" would better indicate the purpose of the
> property. "env.var" is a bit redundant and doesn't really demonstrate that
> this is more about the exclusion of unwanted properties.
>
> Cheers,
>
> Chris
>
> On Mon, Mar 20, 2023 at 6:06 AM Roman Schmitz <ro...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > following up on this KIP ! As there was some discussion as part of the
> > review of the PR (https://github.com/apache/kafka/pull/12992) I'd like
> to
> > inform you about the changes that were made:
> > - The Env-Var-Config provider has been implemented as originally
> discussed.
> > - A security feature was added: Whitelisting the envvars with a regex in
> a
> > property *env.var.pattern* to allow only specific variables to be used to
> > avoid sniffing of sensitive data / variables with defaults to whitelist
> > everything (*).
> > - General agreement was that this feature is nice to have but not
> mandatory
> > for this KIP/PR to be implemented. As it was already implemented while
> > still in discussion we agreed to keep it with a default (*).
> >
> > Cheers,
> > Roman
> >
> > Am Sa., 14. Jan. 2023 um 21:01 Uhr schrieb Roman Schmitz <
> > roman.schmitz@gmail.com>:
> >
> > > Hi all,
> > >
> > > Thanks for the feedback and votes (+4 binding, +4 non-binding)!
> > > I will update the KIP status to accepted and finish my work on the PR (
> > > https://github.com/apache/kafka/pull/12992).
> > >
> > > Thanks,
> > > Roman
> > >
> > > Am Fr., 13. Jan. 2023 um 17:47 Uhr schrieb Lucas Brutschy
> > > <lb...@confluent.io.invalid>:
> > >
> > >> Thanks!
> > >>
> > >> +1 (non-binding)
> > >>
> > >> On Fri, Jan 13, 2023 at 5:42 PM Mickael Maison <
> > mickael.maison@gmail.com>
> > >> wrote:
> > >> >
> > >> > +1 (binding)
> > >> >
> > >> > Thanks for the KIP
> > >> >
> > >> > On Fri, Jan 13, 2023 at 5:31 PM John Roesler <vv...@apache.org>
> > >> wrote:
> > >> > >
> > >> > > Hi Roman,
> > >> > >
> > >> > > Thanks for the KIP!
> > >> > >
> > >> > > I'm +1 (binding)
> > >> > >
> > >> > > -John
> > >> > >
> > >> > > On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
> > >> > > > +1 (non binding)
> > >> > > >
> > >> > > > On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
> > >> > > > <vi...@cloudera.com.invalid> wrote:
> > >> > > >
> > >> > > > > Hi Roman,
> > >> > > > >
> > >> > > > > This seems pretty useful to me (we were also thinking of using
> > >> this kind of
> > >> > > > > feature).
> > >> > > > >
> > >> > > > > +1 (binding)
> > >> > > > >
> > >> > > > > Thanks,
> > >> > > > > Viktor
> > >> > > > >
> > >> > > > > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> > >> > > > > <lb...@confluent.io.invalid> wrote:
> > >> > > > >
> > >> > > > > > Thanks for the KIP! Seems like a useful thing to have. +1
> > >> (non-binding)
> > >> > > > > >
> > >> > > > > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <
> kirk@kirktrue.pro>
> > >> wrote:
> > >> > > > > > >
> > >> > > > > > > I agree that it seems straightforward. +1 (non-binding)
> > >> > > > > > >
> > >> > > > > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > >> > > > > > > > Hi Roman,
> > >> > > > > > > >
> > >> > > > > > > > Thanks for the KIP! I'm +1 (binding)
> > >> > > > > > > >
> > >> > > > > > > > Cheers,
> > >> > > > > > > >
> > >> > > > > > > > Chris
> > >> > > > > > > >
> > >> > > > > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> > >> > > > > roman.schmitz@gmail.com
> > >> > > > > > >
> > >> > > > > > > > wrote:
> > >> > > > > > > >
> > >> > > > > > > > > Hi all,
> > >> > > > > > > > >
> > >> > > > > > > > > Thank you for the feedback so far.
> > >> > > > > > > > > The KIP is rather straightforward and I'd like to
> start
> > a
> > >> vote on
> > >> > > > > it.
> > >> > > > > > > > > Please have a look at the KIP:
> > >> > > > > > > > >
> > >> > > > > >
> > >> > > > >
> > >>
> >
> https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > >> > > > > > > > >
> > >> > > > > > > > > Thanks,
> > >> > > > > > > > > Roman
> > >> > > > > > > > >
> > >> > > > > > > >
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >>
> > >
> >
>
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Chris Egerton <ch...@aiven.io.INVALID>.
Hi Roman,
Thanks for the update. I wonder if the name is a bit unclear? Maybe
something like "allowlist.pattern" would better indicate the purpose of the
property. "env.var" is a bit redundant and doesn't really demonstrate that
this is more about the exclusion of unwanted properties.
Cheers,
Chris
On Mon, Mar 20, 2023 at 6:06 AM Roman Schmitz <ro...@gmail.com>
wrote:
> Hi all,
>
> following up on this KIP ! As there was some discussion as part of the
> review of the PR (https://github.com/apache/kafka/pull/12992) I'd like to
> inform you about the changes that were made:
> - The Env-Var-Config provider has been implemented as originally discussed.
> - A security feature was added: Whitelisting the envvars with a regex in a
> property *env.var.pattern* to allow only specific variables to be used to
> avoid sniffing of sensitive data / variables with defaults to whitelist
> everything (*).
> - General agreement was that this feature is nice to have but not mandatory
> for this KIP/PR to be implemented. As it was already implemented while
> still in discussion we agreed to keep it with a default (*).
>
> Cheers,
> Roman
>
> Am Sa., 14. Jan. 2023 um 21:01 Uhr schrieb Roman Schmitz <
> roman.schmitz@gmail.com>:
>
> > Hi all,
> >
> > Thanks for the feedback and votes (+4 binding, +4 non-binding)!
> > I will update the KIP status to accepted and finish my work on the PR (
> > https://github.com/apache/kafka/pull/12992).
> >
> > Thanks,
> > Roman
> >
> > Am Fr., 13. Jan. 2023 um 17:47 Uhr schrieb Lucas Brutschy
> > <lb...@confluent.io.invalid>:
> >
> >> Thanks!
> >>
> >> +1 (non-binding)
> >>
> >> On Fri, Jan 13, 2023 at 5:42 PM Mickael Maison <
> mickael.maison@gmail.com>
> >> wrote:
> >> >
> >> > +1 (binding)
> >> >
> >> > Thanks for the KIP
> >> >
> >> > On Fri, Jan 13, 2023 at 5:31 PM John Roesler <vv...@apache.org>
> >> wrote:
> >> > >
> >> > > Hi Roman,
> >> > >
> >> > > Thanks for the KIP!
> >> > >
> >> > > I'm +1 (binding)
> >> > >
> >> > > -John
> >> > >
> >> > > On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
> >> > > > +1 (non binding)
> >> > > >
> >> > > > On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
> >> > > > <vi...@cloudera.com.invalid> wrote:
> >> > > >
> >> > > > > Hi Roman,
> >> > > > >
> >> > > > > This seems pretty useful to me (we were also thinking of using
> >> this kind of
> >> > > > > feature).
> >> > > > >
> >> > > > > +1 (binding)
> >> > > > >
> >> > > > > Thanks,
> >> > > > > Viktor
> >> > > > >
> >> > > > > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> >> > > > > <lb...@confluent.io.invalid> wrote:
> >> > > > >
> >> > > > > > Thanks for the KIP! Seems like a useful thing to have. +1
> >> (non-binding)
> >> > > > > >
> >> > > > > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro>
> >> wrote:
> >> > > > > > >
> >> > > > > > > I agree that it seems straightforward. +1 (non-binding)
> >> > > > > > >
> >> > > > > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> >> > > > > > > > Hi Roman,
> >> > > > > > > >
> >> > > > > > > > Thanks for the KIP! I'm +1 (binding)
> >> > > > > > > >
> >> > > > > > > > Cheers,
> >> > > > > > > >
> >> > > > > > > > Chris
> >> > > > > > > >
> >> > > > > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> >> > > > > roman.schmitz@gmail.com
> >> > > > > > >
> >> > > > > > > > wrote:
> >> > > > > > > >
> >> > > > > > > > > Hi all,
> >> > > > > > > > >
> >> > > > > > > > > Thank you for the feedback so far.
> >> > > > > > > > > The KIP is rather straightforward and I'd like to start
> a
> >> vote on
> >> > > > > it.
> >> > > > > > > > > Please have a look at the KIP:
> >> > > > > > > > >
> >> > > > > >
> >> > > > >
> >>
> https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> >> > > > > > > > >
> >> > > > > > > > > Thanks,
> >> > > > > > > > > Roman
> >> > > > > > > > >
> >> > > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >>
> >
>
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Roman Schmitz <ro...@gmail.com>.
Hi all,
following up on this KIP ! As there was some discussion as part of the
review of the PR (https://github.com/apache/kafka/pull/12992) I'd like to
inform you about the changes that were made:
- The Env-Var-Config provider has been implemented as originally discussed.
- A security feature was added: Whitelisting the envvars with a regex in a
property *env.var.pattern* to allow only specific variables to be used to
avoid sniffing of sensitive data / variables with defaults to whitelist
everything (*).
- General agreement was that this feature is nice to have but not mandatory
for this KIP/PR to be implemented. As it was already implemented while
still in discussion we agreed to keep it with a default (*).
Cheers,
Roman
Am Sa., 14. Jan. 2023 um 21:01 Uhr schrieb Roman Schmitz <
roman.schmitz@gmail.com>:
> Hi all,
>
> Thanks for the feedback and votes (+4 binding, +4 non-binding)!
> I will update the KIP status to accepted and finish my work on the PR (
> https://github.com/apache/kafka/pull/12992).
>
> Thanks,
> Roman
>
> Am Fr., 13. Jan. 2023 um 17:47 Uhr schrieb Lucas Brutschy
> <lb...@confluent.io.invalid>:
>
>> Thanks!
>>
>> +1 (non-binding)
>>
>> On Fri, Jan 13, 2023 at 5:42 PM Mickael Maison <mi...@gmail.com>
>> wrote:
>> >
>> > +1 (binding)
>> >
>> > Thanks for the KIP
>> >
>> > On Fri, Jan 13, 2023 at 5:31 PM John Roesler <vv...@apache.org>
>> wrote:
>> > >
>> > > Hi Roman,
>> > >
>> > > Thanks for the KIP!
>> > >
>> > > I'm +1 (binding)
>> > >
>> > > -John
>> > >
>> > > On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
>> > > > +1 (non binding)
>> > > >
>> > > > On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
>> > > > <vi...@cloudera.com.invalid> wrote:
>> > > >
>> > > > > Hi Roman,
>> > > > >
>> > > > > This seems pretty useful to me (we were also thinking of using
>> this kind of
>> > > > > feature).
>> > > > >
>> > > > > +1 (binding)
>> > > > >
>> > > > > Thanks,
>> > > > > Viktor
>> > > > >
>> > > > > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
>> > > > > <lb...@confluent.io.invalid> wrote:
>> > > > >
>> > > > > > Thanks for the KIP! Seems like a useful thing to have. +1
>> (non-binding)
>> > > > > >
>> > > > > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro>
>> wrote:
>> > > > > > >
>> > > > > > > I agree that it seems straightforward. +1 (non-binding)
>> > > > > > >
>> > > > > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
>> > > > > > > > Hi Roman,
>> > > > > > > >
>> > > > > > > > Thanks for the KIP! I'm +1 (binding)
>> > > > > > > >
>> > > > > > > > Cheers,
>> > > > > > > >
>> > > > > > > > Chris
>> > > > > > > >
>> > > > > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
>> > > > > roman.schmitz@gmail.com
>> > > > > > >
>> > > > > > > > wrote:
>> > > > > > > >
>> > > > > > > > > Hi all,
>> > > > > > > > >
>> > > > > > > > > Thank you for the feedback so far.
>> > > > > > > > > The KIP is rather straightforward and I'd like to start a
>> vote on
>> > > > > it.
>> > > > > > > > > Please have a look at the KIP:
>> > > > > > > > >
>> > > > > >
>> > > > >
>> https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
>> > > > > > > > >
>> > > > > > > > > Thanks,
>> > > > > > > > > Roman
>> > > > > > > > >
>> > > > > > > >
>> > > > > >
>> > > > >
>> > > >
>>
>
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Roman Schmitz <ro...@gmail.com>.
Hi all,
Thanks for the feedback and votes (+4 binding, +4 non-binding)!
I will update the KIP status to accepted and finish my work on the PR (
https://github.com/apache/kafka/pull/12992).
Thanks,
Roman
Am Fr., 13. Jan. 2023 um 17:47 Uhr schrieb Lucas Brutschy
<lb...@confluent.io.invalid>:
> Thanks!
>
> +1 (non-binding)
>
> On Fri, Jan 13, 2023 at 5:42 PM Mickael Maison <mi...@gmail.com>
> wrote:
> >
> > +1 (binding)
> >
> > Thanks for the KIP
> >
> > On Fri, Jan 13, 2023 at 5:31 PM John Roesler <vv...@apache.org>
> wrote:
> > >
> > > Hi Roman,
> > >
> > > Thanks for the KIP!
> > >
> > > I'm +1 (binding)
> > >
> > > -John
> > >
> > > On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
> > > > +1 (non binding)
> > > >
> > > > On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
> > > > <vi...@cloudera.com.invalid> wrote:
> > > >
> > > > > Hi Roman,
> > > > >
> > > > > This seems pretty useful to me (we were also thinking of using
> this kind of
> > > > > feature).
> > > > >
> > > > > +1 (binding)
> > > > >
> > > > > Thanks,
> > > > > Viktor
> > > > >
> > > > > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> > > > > <lb...@confluent.io.invalid> wrote:
> > > > >
> > > > > > Thanks for the KIP! Seems like a useful thing to have. +1
> (non-binding)
> > > > > >
> > > > > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro>
> wrote:
> > > > > > >
> > > > > > > I agree that it seems straightforward. +1 (non-binding)
> > > > > > >
> > > > > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > > > > > > > Hi Roman,
> > > > > > > >
> > > > > > > > Thanks for the KIP! I'm +1 (binding)
> > > > > > > >
> > > > > > > > Cheers,
> > > > > > > >
> > > > > > > > Chris
> > > > > > > >
> > > > > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> > > > > roman.schmitz@gmail.com
> > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Hi all,
> > > > > > > > >
> > > > > > > > > Thank you for the feedback so far.
> > > > > > > > > The KIP is rather straightforward and I'd like to start a
> vote on
> > > > > it.
> > > > > > > > > Please have a look at the KIP:
> > > > > > > > >
> > > > > >
> > > > >
> https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Roman
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > > >
> > > >
>
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Lucas Brutschy <lb...@confluent.io.INVALID>.
Thanks!
+1 (non-binding)
On Fri, Jan 13, 2023 at 5:42 PM Mickael Maison <mi...@gmail.com> wrote:
>
> +1 (binding)
>
> Thanks for the KIP
>
> On Fri, Jan 13, 2023 at 5:31 PM John Roesler <vv...@apache.org> wrote:
> >
> > Hi Roman,
> >
> > Thanks for the KIP!
> >
> > I'm +1 (binding)
> >
> > -John
> >
> > On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
> > > +1 (non binding)
> > >
> > > On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
> > > <vi...@cloudera.com.invalid> wrote:
> > >
> > > > Hi Roman,
> > > >
> > > > This seems pretty useful to me (we were also thinking of using this kind of
> > > > feature).
> > > >
> > > > +1 (binding)
> > > >
> > > > Thanks,
> > > > Viktor
> > > >
> > > > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> > > > <lb...@confluent.io.invalid> wrote:
> > > >
> > > > > Thanks for the KIP! Seems like a useful thing to have. +1 (non-binding)
> > > > >
> > > > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro> wrote:
> > > > > >
> > > > > > I agree that it seems straightforward. +1 (non-binding)
> > > > > >
> > > > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > > > > > > Hi Roman,
> > > > > > >
> > > > > > > Thanks for the KIP! I'm +1 (binding)
> > > > > > >
> > > > > > > Cheers,
> > > > > > >
> > > > > > > Chris
> > > > > > >
> > > > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> > > > roman.schmitz@gmail.com
> > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > Thank you for the feedback so far.
> > > > > > > > The KIP is rather straightforward and I'd like to start a vote on
> > > > it.
> > > > > > > > Please have a look at the KIP:
> > > > > > > >
> > > > >
> > > > https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Roman
> > > > > > > >
> > > > > > >
> > > > >
> > > >
> > >
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Mickael Maison <mi...@gmail.com>.
+1 (binding)
Thanks for the KIP
On Fri, Jan 13, 2023 at 5:31 PM John Roesler <vv...@apache.org> wrote:
>
> Hi Roman,
>
> Thanks for the KIP!
>
> I'm +1 (binding)
>
> -John
>
> On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
> > +1 (non binding)
> >
> > On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
> > <vi...@cloudera.com.invalid> wrote:
> >
> > > Hi Roman,
> > >
> > > This seems pretty useful to me (we were also thinking of using this kind of
> > > feature).
> > >
> > > +1 (binding)
> > >
> > > Thanks,
> > > Viktor
> > >
> > > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> > > <lb...@confluent.io.invalid> wrote:
> > >
> > > > Thanks for the KIP! Seems like a useful thing to have. +1 (non-binding)
> > > >
> > > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro> wrote:
> > > > >
> > > > > I agree that it seems straightforward. +1 (non-binding)
> > > > >
> > > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > > > > > Hi Roman,
> > > > > >
> > > > > > Thanks for the KIP! I'm +1 (binding)
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Chris
> > > > > >
> > > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> > > roman.schmitz@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > Thank you for the feedback so far.
> > > > > > > The KIP is rather straightforward and I'd like to start a vote on
> > > it.
> > > > > > > Please have a look at the KIP:
> > > > > > >
> > > >
> > > https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Roman
> > > > > > >
> > > > > >
> > > >
> > >
> >
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by John Roesler <vv...@apache.org>.
Hi Roman,
Thanks for the KIP!
I'm +1 (binding)
-John
On 2023/01/02 15:48:56 Knowles Atchison Jr wrote:
> +1 (non binding)
>
> On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
> <vi...@cloudera.com.invalid> wrote:
>
> > Hi Roman,
> >
> > This seems pretty useful to me (we were also thinking of using this kind of
> > feature).
> >
> > +1 (binding)
> >
> > Thanks,
> > Viktor
> >
> > On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> > <lb...@confluent.io.invalid> wrote:
> >
> > > Thanks for the KIP! Seems like a useful thing to have. +1 (non-binding)
> > >
> > > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro> wrote:
> > > >
> > > > I agree that it seems straightforward. +1 (non-binding)
> > > >
> > > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > > > > Hi Roman,
> > > > >
> > > > > Thanks for the KIP! I'm +1 (binding)
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Chris
> > > > >
> > > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> > roman.schmitz@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > Thank you for the feedback so far.
> > > > > > The KIP is rather straightforward and I'd like to start a vote on
> > it.
> > > > > > Please have a look at the KIP:
> > > > > >
> > >
> > https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > > > > >
> > > > > > Thanks,
> > > > > > Roman
> > > > > >
> > > > >
> > >
> >
>
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Knowles Atchison Jr <ka...@gmail.com>.
+1 (non binding)
On Mon, Jan 2, 2023, 9:15 AM Viktor Somogyi-Vass
<vi...@cloudera.com.invalid> wrote:
> Hi Roman,
>
> This seems pretty useful to me (we were also thinking of using this kind of
> feature).
>
> +1 (binding)
>
> Thanks,
> Viktor
>
> On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
> <lb...@confluent.io.invalid> wrote:
>
> > Thanks for the KIP! Seems like a useful thing to have. +1 (non-binding)
> >
> > On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro> wrote:
> > >
> > > I agree that it seems straightforward. +1 (non-binding)
> > >
> > > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > > > Hi Roman,
> > > >
> > > > Thanks for the KIP! I'm +1 (binding)
> > > >
> > > > Cheers,
> > > >
> > > > Chris
> > > >
> > > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <
> roman.schmitz@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > Thank you for the feedback so far.
> > > > > The KIP is rather straightforward and I'd like to start a vote on
> it.
> > > > > Please have a look at the KIP:
> > > > >
> >
> https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > > > >
> > > > > Thanks,
> > > > > Roman
> > > > >
> > > >
> >
>
Re: [VOTE] KIP-887 - Add ConfigProvider to make use of environment variables
Posted by Viktor Somogyi-Vass <vi...@cloudera.com.INVALID>.
Hi Roman,
This seems pretty useful to me (we were also thinking of using this kind of
feature).
+1 (binding)
Thanks,
Viktor
On Mon, Jan 2, 2023 at 9:19 AM Lucas Brutschy
<lb...@confluent.io.invalid> wrote:
> Thanks for the KIP! Seems like a useful thing to have. +1 (non-binding)
>
> On Tue, Dec 27, 2022 at 7:20 PM Kirk True <ki...@kirktrue.pro> wrote:
> >
> > I agree that it seems straightforward. +1 (non-binding)
> >
> > On Tue, Dec 27, 2022, at 9:24 AM, Chris Egerton wrote:
> > > Hi Roman,
> > >
> > > Thanks for the KIP! I'm +1 (binding)
> > >
> > > Cheers,
> > >
> > > Chris
> > >
> > > On Wed, Dec 14, 2022 at 3:52 PM Roman Schmitz <roman.schmitz@gmail.com
> >
> > > wrote:
> > >
> > > > Hi all,
> > > >
> > > > Thank you for the feedback so far.
> > > > The KIP is rather straightforward and I'd like to start a vote on it.
> > > > Please have a look at the KIP:
> > > >
> https://eu01.z.antigena.com/l/EXPIk5DmddkPFlqfPnlswu2VHYg_8h-TuWq8d3DskL7C2Rgsv7AwoRLT9J1PT-WH2TaJ9SSZSW9IvgzjtTq4ksyl~QkZThD9b5tl_IhLpkq_OT2u-nL~lu3jT3a3DabKzOo5NUdNPsmM34PAefwMFE~QOWHNaYIqWpXSIsu2IXd_C_4
> > > >
> > > > Thanks,
> > > > Roman
> > > >
> > >
>