You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/12/20 03:50:55 UTC
Review Request 64743: Enabled function sections.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
Repository: mesos
Description
-------
If we tell the compiler to place each function in a separate
section, this allows the linker to garbage collect unused
sections. This significantly decreases the size of the final
build artifacts and provides some modest improvements in build
times.
This feature is currently only implemented in Linux toolchains,
so we automatically enable it only on Linux.
Diffs
-----
cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
Diff: https://reviews.apache.org/r/64743/diff/1/
Testing
-------
make check
Thanks,
James Peach
Re: Review Request 64743: Enabled function sections.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review194705
-----------------------------------------------------------
Ship it!
I can't vouch for the compiler flags themselves, but the CMake part looks good and appears consistent with the Autotools changes; moreover, it passed on the Windows ReviewBot, so it _is_ correctly not adding the flags if the check for their support failed.
- Andrew Schwartzmeyer
On Dec. 20, 2017, 5:47 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 5:47 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
> configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
>
>
> Diff: https://reviews.apache.org/r/64743/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review194303
-----------------------------------------------------------
PASS: Mesos patch 64743 was successfully built and tested.
Reviews applied: `['64743']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64743
- Mesos Reviewbot Windows
On Dec. 21, 2017, 1:47 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 1:47 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
> configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
>
>
> Diff: https://reviews.apache.org/r/64743/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by James Peach <jp...@apache.org>.
> On Jan. 9, 2018, 4:10 p.m., Benjamin Bannier wrote:
> > Thanks for adjusting this.
> >
> > It would be great if you could update the ticket with e.g., benchmark results so people get a first feel for whether it makes sense for them to enable this feature in production builds.
Added a quick benchmark to the JIRA. No obvious perf impact on that particular benchmark.
> On Jan. 9, 2018, 4:10 p.m., Benjamin Bannier wrote:
> > configure.ac
> > Lines 175 (patched)
> > <https://reviews.apache.org/r/64743/diff/5/?file=1930931#file1930931line175>
> >
> > I wonder whether it would make sense to use a more high-level name for this (in the end this is about using sections which can be gc'ed, not just function sections).
Changed to `--enable-gc-unused` as per chat.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review195039
-----------------------------------------------------------
On Jan. 9, 2018, 6:40 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2018, 6:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318
> configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421
> docs/configuration/autotools.md c6ac196fd5023391143313821185cac096b41a2b
> docs/configuration/cmake.md 5364b1e0398e8e774c89993bd7404c32abe3bedc
>
>
> Diff: https://reviews.apache.org/r/64743/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review195039
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for adjusting this.
It would be great if you could update the ticket with e.g., benchmark results so people get a first feel for whether it makes sense for them to enable this feature in production builds.
cmake/CompilationConfigure.cmake
Lines 260 (patched)
<https://reviews.apache.org/r/64743/#comment274163>
Also wondering what more high-levely name we could pick here instead.
cmake/CompilationConfigure.cmake
Lines 264 (patched)
<https://reviews.apache.org/r/64743/#comment274160>
Could you document this flag in `docs/configuration/cmake.md`?
cmake/CompilationConfigure.cmake
Lines 269 (patched)
<https://reviews.apache.org/r/64743/#comment274159>
Similar to the autotools setup, we should emit a hard error on an additional `else` branch here.
configure.ac
Lines 175 (patched)
<https://reviews.apache.org/r/64743/#comment274162>
I wonder whether it would make sense to use a more high-level name for this (in the end this is about using sections which can be gc'ed, not just function sections).
configure.ac
Lines 505 (patched)
<https://reviews.apache.org/r/64743/#comment274161>
Could you document this flag in `docs/configuration/autotools.md`?
configure.ac
Lines 527 (patched)
<https://reviews.apache.org/r/64743/#comment274158>
This is a little weird.
As a user I wouldn't expect my configuration to be silently dropped if it is not supported, but preferably a hard error until configuration and platform are compatible.
Could you insert a check for compatibility of `enable_function_sections` and `function_sections` here and error out if they are not incompatible?
- Benjamin Bannier
On Jan. 4, 2018, 10:48 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 10:48 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318
> configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421
>
>
> Diff: https://reviews.apache.org/r/64743/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review195045
-----------------------------------------------------------
PASS: Mesos patch 64743 was successfully built and tested.
Reviews applied: `['64743']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64743
- Mesos Reviewbot Windows
On Jan. 4, 2018, 9:48 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2018, 9:48 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318
> configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421
>
>
> Diff: https://reviews.apache.org/r/64743/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review195064
-----------------------------------------------------------
PASS: Mesos patch 64743 was successfully built and tested.
Reviews applied: `['64743']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64743
- Mesos Reviewbot Windows
On Jan. 9, 2018, 6:40 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2018, 6:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318
> configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421
> docs/configuration/autotools.md c6ac196fd5023391143313821185cac096b41a2b
> docs/configuration/cmake.md 5364b1e0398e8e774c89993bd7404c32abe3bedc
>
>
> Diff: https://reviews.apache.org/r/64743/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/
-----------------------------------------------------------
(Updated Jan. 9, 2018, 6:40 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
Bugs: MESOS-8348
https://issues.apache.org/jira/browse/MESOS-8348
Repository: mesos
Description
-------
If we tell the compiler to place each function in a separate
section, this allows the linker to garbage collect unused
sections. This significantly decreases the size of the final
build artifacts and provides some modest improvements in build
times.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318
configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421
docs/configuration/autotools.md c6ac196fd5023391143313821185cac096b41a2b
docs/configuration/cmake.md 5364b1e0398e8e774c89993bd7404c32abe3bedc
Diff: https://reviews.apache.org/r/64743/diff/6/
Changes: https://reviews.apache.org/r/64743/diff/5-6/
Testing
-------
make check
Thanks,
James Peach
Re: Review Request 64743: Enabled function sections.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/
-----------------------------------------------------------
(Updated Jan. 4, 2018, 9:48 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
Changes
-------
Added build configuration to enable this.
Bugs: MESOS-8348
https://issues.apache.org/jira/browse/MESOS-8348
Repository: mesos
Description
-------
If we tell the compiler to place each function in a separate
section, this allows the linker to garbage collect unused
sections. This significantly decreases the size of the final
build artifacts and provides some modest improvements in build
times.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 0ae05047265e33aefab6eef67a4243b6b00f0318
configure.ac b6eb98bfe5539c68a416831c36c182ee907d9421
Diff: https://reviews.apache.org/r/64743/diff/4/
Changes: https://reviews.apache.org/r/64743/diff/3-4/
Testing
-------
make check
Thanks,
James Peach
Re: Review Request 64743: Enabled function sections.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/
-----------------------------------------------------------
(Updated Dec. 21, 2017, 1:47 a.m.)
Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
Bugs: MESOS-8348
https://issues.apache.org/jira/browse/MESOS-8348
Repository: mesos
Description (updated)
-------
If we tell the compiler to place each function in a separate
section, this allows the linker to garbage collect unused
sections. This significantly decreases the size of the final
build artifacts and provides some modest improvements in build
times.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
Diff: https://reviews.apache.org/r/64743/diff/2/
Changes: https://reviews.apache.org/r/64743/diff/1-2/
Testing
-------
make check
Thanks,
James Peach
Re: Review Request 64743: Enabled function sections.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review194211
-----------------------------------------------------------
Is [this -Gy MSVC option](https://docs.microsoft.com/en-us/cpp/build/reference/gy-enable-function-level-linking) equivalent?
> You can use the linker option /OPT (Optimizations) to exclude unreferenced packaged functions from the .exe file.
- Andrew Schwartzmeyer
On Dec. 19, 2017, 7:50 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 7:50 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
> This feature is currently only implemented in Linux toolchains,
> so we automatically enable it only on Linux.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
> configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
>
>
> Diff: https://reviews.apache.org/r/64743/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by James Peach <jp...@apache.org>.
> On Dec. 20, 2017, 10:52 a.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 267 (patched)
> > <https://reviews.apache.org/r/64743/diff/1/?file=1924221#file1924221line267>
> >
> > What about static archives? Last time I looked this was broken in the cmake setup, but it would be great to prepare to also make use of this flag there once its ready (if applicable).
GC sections can't really apply to archives since you don't know which sections it is safe to GC.
> On Dec. 20, 2017, 10:52 a.m., Benjamin Bannier wrote:
> > configure.ac
> > Lines 507-508 (patched)
> > <https://reviews.apache.org/r/64743/diff/1/?file=1924222#file1924222line507>
> >
> > Why are we disabling this on macos? These flags do work with the latest LLVM toolchain (clang & lld), so let's default-enable it on macos as well.
> >
> > If you worry about some Apple clang fork not supporting these flags, let's please add some feature detection instead of branching on the platform here.
Switched to just enabling it wherever it works.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review194224
-----------------------------------------------------------
On Dec. 21, 2017, 1:47 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 1:47 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
> configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
>
>
> Diff: https://reviews.apache.org/r/64743/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review194224
-----------------------------------------------------------
cmake/CompilationConfigure.cmake
Line 262 (original), 262 (patched)
<https://reviews.apache.org/r/64743/#comment272943>
Since we have a configure flag to disable these in autotools land, let's also add some cmake option to turn this off.
cmake/CompilationConfigure.cmake
Lines 263 (patched)
<https://reviews.apache.org/r/64743/#comment272940>
Let's not depend on the platform, but instead on the toolchain instead. This does work on e.g., macos.
cmake/CompilationConfigure.cmake
Lines 264-265 (patched)
<https://reviews.apache.org/r/64743/#comment272944>
Let's merge these lines.
cmake/CompilationConfigure.cmake
Lines 267 (patched)
<https://reviews.apache.org/r/64743/#comment272942>
What about static archives? Last time I looked this was broken in the cmake setup, but it would be great to prepare to also make use of this flag there once its ready (if applicable).
configure.ac
Lines 178 (patched)
<https://reviews.apache.org/r/64743/#comment272939>
We already have two forms for handling of configure default args, one explicit (e.g., right above), and another one for e.g., `parallel-test-execution` or `werror`.
I'd suggest to just follow the flow of `werror` instead of introducing yet another approach. That would make the eventual cleanup possibly less upsetting.
configure.ac
Lines 507-508 (patched)
<https://reviews.apache.org/r/64743/#comment272938>
Why are we disabling this on macos? These flags do work with the latest LLVM toolchain (clang & lld), so let's default-enable it on macos as well.
If you worry about some Apple clang fork not supporting these flags, let's please add some feature detection instead of branching on the platform here.
- Benjamin Bannier
On Dec. 20, 2017, 4:50 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 4:50 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
> This feature is currently only implemented in Linux toolchains,
> so we automatically enable it only on Linux.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
> configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
>
>
> Diff: https://reviews.apache.org/r/64743/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64743: Enabled function sections.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64743/#review194216
-----------------------------------------------------------
PASS: Mesos patch 64743 was successfully built and tested.
Reviews applied: `['64743']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64743
- Mesos Reviewbot Windows
On Dec. 20, 2017, 3:50 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64743/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 3:50 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8348
> https://issues.apache.org/jira/browse/MESOS-8348
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we tell the compiler to place each function in a separate
> section, this allows the linker to garbage collect unused
> sections. This significantly decreases the size of the final
> build artifacts and provides some modest improvements in build
> times.
>
> This feature is currently only implemented in Linux toolchains,
> so we automatically enable it only on Linux.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2
> configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348
>
>
> Diff: https://reviews.apache.org/r/64743/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>