You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/26 17:46:01 UTC

[GitHub] [kafka] mimaison commented on a change in pull request #9597: KAFKA-10720: Document prohibition on header mutation by SMTs

mimaison commented on a change in pull request #9597:
URL: https://github.com/apache/kafka/pull/9597#discussion_r531168400



##########
File path: connect/api/src/main/java/org/apache/kafka/connect/transforms/Transformation.java
##########
@@ -33,6 +33,11 @@
      * Apply transformation to the {@code record} and return another record object (which may be {@code record} itself) or {@code null},
      * corresponding to a map or filter operation respectively.
      *
+     * A transformation must not mutate objects reachable from the given {@code record}
+     * (including, but not limited to, {@link org.apache.kafka.connect.header.Headers},

Review comment:
       Should we change `{@link org.apache.kafka.connect.header.Headers}` to `{@link org.apache.kafka.connect.header.Headers Headers}` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org