You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "David Byrne (JIRA)" <ji...@apache.org> on 2007/12/15 03:49:43 UTC

[jira] Created: (HTTPCLIENT-719) Clone support

Clone support
-------------

                 Key: HTTPCLIENT-719
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: HttpCookie
            Reporter: David Byrne
            Priority: Minor


It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 

Thanks,
David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Commented: (HTTPCLIENT-719) Clone support

Posted by "David Byrne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12555008 ] 

David Byrne commented on HTTPCLIENT-719:
----------------------------------------

Oleg,

Sorry for the slow response. I've been tied up with the holidays, etc. I'm not concerned if the classes aren't strictly "cloneable"; I just want to make a copy. I hadn't considered the  problems with streaming entities, but your idea makes sense.

Thanks,
David



> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0 Alpha 3
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-719) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-719:
-----------------------------------------

    Fix Version/s: 4.0 Alpha 3

> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0 Alpha 3
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-719) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-719:
-----------------------------------------

    Fix Version/s:     (was: 4.0 Alpha 4)
                   4.0 Alpha 5 

> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0 Alpha 5 
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-719) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-719:
-----------------------------------------

    Fix Version/s:     (was: 4.0 Alpha 3)
                   4.0 Alpha 4

It turned out some minor changes needed to be done to AbstractHttpMessage in core in order to resolve the issue (some instance variables are currently declared private final and therefore cannot be deep-copied). Pushing back to alpha4

Oleg  

> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0 Alpha 4
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-719) Clone support

Posted by "David Byrne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Byrne updated HTTPCLIENT-719:
-----------------------------------

    Component/s: HttpClient

> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Commented: (HTTPCLIENT-719) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552202 ] 

Oleg Kalnichevski commented on HTTPCLIENT-719:
----------------------------------------------

Both HttpRequest and Cookie may be difficult to clone by means of standard Cloneable, #clone() partially due to the fact it is utterly broken. What we could do is to provide a Copyable interface that could be used to produce equivalent copies of complex compound objects. HTTP messages with streaming entities could buffer the content in order to make it copyable. 

Thoughts?

Oleg

> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0 Alpha 3
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCLIENT-719) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-719.
------------------------------------------

    Resolution: Fixed

Resolved in SVN trunk.

Oleg

> Clone support
> -------------
>
>                 Key: HTTPCLIENT-719
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-719
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient, HttpCookie
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0 Alpha 5 
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. The main interfaces that I would like to clone are HttpRequest and Cookie. I know that HttpRequest is technically part of HttpCore, but the primary implementations of it are in HttpClient, so I thought I would post it here. 
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org