You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/19 03:07:27 UTC

[GitHub] [kylin] hit-lacus opened a new pull request #1070: KYLIN-4312 Specified cube when querying by API

hit-lacus opened a new pull request #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070
 
 
   Backend part

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus merged pull request #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus edited a comment on issue #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on issue #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070#issuecomment-581298747
 
 
   ## Test
   #### Env
   Safari and chrome in latest mac os.
   
   #### Prepare
   ![image](https://user-images.githubusercontent.com/14030549/73637679-d2e41d00-46a3-11ea-839e-fb8cb586c456.png)
   
   
   #### Test Query
   - Force hit `SECOND_KYLIN_SALES`
   ![image](https://user-images.githubusercontent.com/14030549/73637495-6832e180-46a3-11ea-93fc-4ea7757e282a.png)
   
   - Force hit `FIRST_KYLIN_SALES`
   
   ![image](https://user-images.githubusercontent.com/14030549/73637610-b2b45e00-46a3-11ea-9f6d-7dcbf612da51.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070#issuecomment-576180468
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=h1) Report
   > Merging [#1070](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b87753fa4b49d4016f846fc2e35a36d611d6c8b4?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1070/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1070      +/-   ##
   ============================================
   - Coverage     25.05%   25.05%   -0.01%     
   + Complexity     6223     6222       -1     
   ============================================
     Files          1438     1438              
     Lines         87729    87734       +5     
     Branches      12257    12258       +1     
   ============================================
   - Hits          21984    21982       -2     
   - Misses        63596    63602       +6     
   - Partials       2149     2150       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...va/org/apache/kylin/query/routing/QueryRouter.java](https://codecov.io/gh/apache/kylin/pull/1070/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3JvdXRpbmcvUXVlcnlSb3V0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...org/apache/kylin/common/debug/BackdoorToggles.java](https://codecov.io/gh/apache/kylin/pull/1070/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9kZWJ1Zy9CYWNrZG9vclRvZ2dsZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1070/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1070/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   | [...rg/apache/kylin/metadata/TableMetadataManager.java](https://codecov.io/gh/apache/kylin/pull/1070/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvVGFibGVNZXRhZGF0YU1hbmFnZXIuamF2YQ==) | `58.2% <0%> (-0.3%)` | `26% <0%> (ø)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1070/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=footer). Last update [b87753f...5bd802d](https://codecov.io/gh/apache/kylin/pull/1070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070#issuecomment-576178982
 
 
   ## Pull Request Test Coverage Report for [Build 5544](https://coveralls.io/builds/28205574)
   
   * **0** of **4**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * **11** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.007%**) to **27.509%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-common/src/main/java/org/apache/kylin/common/debug/BackdoorToggles.java](https://coveralls.io/builds/28205574/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fdebug%2FBackdoorToggles.java#L75) | 0 | 1 | 0.0%
   | [query/src/main/java/org/apache/kylin/query/routing/QueryRouter.java](https://coveralls.io/builds/28205574/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frouting%2FQueryRouter.java#L57) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **4** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28205574/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   | [query/src/main/java/org/apache/kylin/query/routing/QueryRouter.java](https://coveralls.io/builds/28205574/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frouting%2FQueryRouter.java#L61) | 1 | 0% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/28205574/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/28205574/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L80) | 2 | 57.95% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28205574/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   <!-- | **Total:** | **11** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28205574/badge)](https://coveralls.io/builds/28205574) |
   | :-- | --: |
   | Change from base [Build 5537](https://coveralls.io/builds/28193424): |  -0.007% |
   | Covered Lines: | 24135 |
   | Relevant Lines: | 87734 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070#issuecomment-581298747
 
 
   
   ## Env
   Safari and chrome in latest mac os.
   
   #### Prepare
   ![image](https://user-images.githubusercontent.com/14030549/73637679-d2e41d00-46a3-11ea-839e-fb8cb586c456.png)
   
   
   #### Test Query
   - Force hit `SECOND_KYLIN_SALES`
   ![image](https://user-images.githubusercontent.com/14030549/73637495-6832e180-46a3-11ea-93fc-4ea7757e282a.png)
   
   - Force hit `FIRST_KYLIN_SALES`
   
   ![image](https://user-images.githubusercontent.com/14030549/73637610-b2b45e00-46a3-11ea-9f6d-7dcbf612da51.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070#issuecomment-581301351
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1070: KYLIN-4312 Specified cube when querying by API

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1070: KYLIN-4312 Specified cube when querying by API
URL: https://github.com/apache/kylin/pull/1070#issuecomment-575962251
 
 
   ## 需求背景
   
   1. 数据缺失
   比如A这个人 她想查abcf四个维度 ，B这个人她想查bcd这三个维度，指标都一样。但是A是在 1月3号建了Cube，B是在8号建的Cube。
   这时候我查bc这两个维度的时候就会命中B的cube ，那前面的时间就没有了
   
   2. 满足测试
   测试时无法测试特定的Cube，只能频繁地Enable Disable Cube
   
   ## 测试
   
   1. 为两个设置相同的Cube 分别构建Segment，但是Segment Range不同
   <img width="1228" alt="image" src="https://user-images.githubusercontent.com/14030549/71353852-3c591200-25b5-11ea-81b9-1996b6584b2b.png">
   
   2. WebUI 查询
   
   命中`SimpleCube_02`
   <img width="1051" alt="image" src="https://user-images.githubusercontent.com/14030549/71354009-a1ad0300-25b5-11ea-9f10-8d1bb02eb6d9.png">
   
   3. 强制切换Cube，使之命中 `SimpleCube_01`
   
   ```json
   {  
      "sql":"select part_dt, count(*) from KYLIN_SALES group by part_dt order by part_dt",
      "offset":0,
      "limit":50000,
      "acceptPartial":false,
      "project":"learn_kylin",
      "backdoorToggles":{"DEBUG_TOGGLE_HIT_CUBE":"SimpleCube_01"}
   }
   ```
   <img width="976" alt="image" src="https://user-images.githubusercontent.com/14030549/71354156-049e9a00-25b6-11ea-8d80-1907da838f04.png">

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services