[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

["Gian Merlino (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691732#comment-17691732 ] 

Gian Merlino commented on CALCITE-5477:
---------------------------------------

That sounds fair enough. I will try this approach out, and then update my PR to do as you describe. Afterwards, I'll also do the best I can to get us past the Guava 16 stuff in Druid world.

> Compatibility with Guava < 20.0
> -------------------------------
>
>                 Key: CALCITE-5477
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5477
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Gian Merlino
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Related to CALCITE-5428.
> Preconditions.checkArgument gained new overloads in Guava 20.0, which prevents code built using Guava 20.0 from running properly with earlier versions of Guava. (When building against a later version of Guava, as Calcite does by default, the Java compiler generates calls to methods that don't exist in those earlier versions.)
> Example: in Guava 20.0 there is {{checkArgument(boolean, String, int)}}; in earlier versions this would be handled by {{checkArgument(boolean, String, Object...)}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)