You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/20 02:09:43 UTC

[GitHub] doctording opened a new issue #5438: delete dashboard redirect to 404 Not Found page

doctording opened a new issue #5438: delete dashboard redirect to 404 Not Found page 
URL: https://github.com/apache/incubator-superset/issues/5438
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if any
   - [x ] I have reproduced the issue with at least the latest released version of superset
   - [x ] I have checked the issue tracker for the same issue and I haven't found one similar
   
   
   ### Superset version
   0.26.3
   
   ### Expected results
   
   ![image](https://user-images.githubusercontent.com/11834821/42978725-16b391f0-8c01-11e8-945a-b8a56f22698c.png)
   
   1. create a dashboard named "del-test"
   2. then redirect to other page, such as "http://localhost:8088/dashboardmodelview/show/5"
   3. just use the browser's forward and back buttons, then back to "http://localhost:8088/dashboardmodelview/list/"
   ![image](https://user-images.githubusercontent.com/11834821/42978921-26e96594-8c02-11e8-84ba-540d6141aee4.png)
   4. delete dashboard, then redirect to a 404 page 
   ![image](https://user-images.githubusercontent.com/11834821/42978942-3e75aa1a-8c02-11e8-81eb-79b3e1cf64a2.png)
   
   we can see that after delete that dash board, the redirect url is "dashboardmodelview/show/5", not "dashboardmodelview/list/". Using the browser's forward and backward switch does not send a request request, the last url stored in the session is still "dashboardmodelview/show/5"。
   
   ### Actual results
   
   it should redirect to "dashboardmodelview/list/".
   
   I have checked the code, the delete method could be overridden to redirect to the default_url("dashboardmodelview/list/") 
   ```python
   @expose('/delete/<pk>')
       @has_access
       def delete(self, pk):
   ```
   
   ### Steps to reproduce
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org