[GitHub] [solr] risdenk commented on a diff in pull request #943: SOLR-15342: Separate out a SolrJ-Zookeeper module

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r952737321


##########
solr/solrj/build.gradle:
##########
@@ -50,20 +41,16 @@ dependencies {
   implementation 'org.apache.httpcomponents:httpclient'
   implementation 'org.apache.httpcomponents:httpcore'
 
-  implementation('org.apache.zookeeper:zookeeper', {
-    exclude group: "org.apache.yetus", module: "audience-annotations"
-    exclude group: "log4j", module: "log4j"
-    exclude group: "org.slf4j", module: "slf4j-log4j12"
-  })
-  implementation ('org.apache.zookeeper:zookeeper-jute') {
-    exclude group: 'org.apache.yetus', module: 'audience-annotations'
-  }
-
   testImplementation project(':solr:test-framework')
   testImplementation project(':solr:core')
   testImplementation project(':solr:solrj')
   testRuntimeOnly project(':solr:modules:sql')
 
+  // ideally ZK centric tests move to solrj-zookeeper but sometimes we depend on ZK here anyway
+  testImplementation project(':solr:solrj-zookeeper')
+  testImplementation 'org.apache.zookeeper:zookeeper'
+  permitTestUnusedDeclared 'org.apache.zookeeper:zookeeper'

Review Comment:
   Hmmm thats interesting - we have very very few of these in the code already.
   
   ```
   ➜  solr git:(SOLR-16187) git grep -F Unused | grep -F build.gradle
   solr/core/build.gradle:  permitUnusedDeclared 'com.github.spotbugs:spotbugs-annotations'
   solr/modules/hadoop-auth/build.gradle:  permitUnusedDeclared 'com.github.spotbugs:spotbugs-annotations'
   solr/modules/hadoop-auth/build.gradle:  permitUnusedDeclared 'org.apache.hadoop:hadoop-annotations'
   solr/modules/hdfs/build.gradle:  permitTestUnusedDeclared 'org.apache.zookeeper:zookeeper'
   solr/modules/jwt-auth/build.gradle:  //permitTestUnusedDeclared 'com.fasterxml.jackson.core:jackson-databind'
   solr/modules/sql/build.gradle:  permitUnusedDeclared 'org.apache.calcite.avatica:avatica-core'
   solr/solrj/build.gradle:  permitUnusedDeclared 'com.github.spotbugs:spotbugs-annotations'
   solr/test-framework/build.gradle:  permitUnusedDeclared 'com.github.spotbugs:spotbugs-annotations'
   solr/test-framework/build.gradle:  permitUnusedDeclared 'commons-cli:commons-cli'
   solr/webapp/build.gradle:  permitUnusedDeclared project(":solr:core")
   ```
   
   Most of these are spotbugs annotations. I know there were bugs in older versions of the plugin. The hdfs module does have the same thing for zookeeper. So I'm not really sure what is going on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org