Re: svn commit: rev 5757 - branches/cvs2svn-kfogel/tools/cvs2svn

[Karl Fogel <kf...@newton.ch.collab.net>]

Greg Stein <gs...@lyra.org> writes:
> > +    total_len = 10                                     # 'PROPS-END\n'
> > +    for propname in props.keys():
> > +      klen = len(propname) + 1                         # propname + '\n'
> > +      klen_len = int(math.ceil(math.log10(klen))) + 3  # 'K ' + klen + '\n'
> 
> Can we just toss the 'math' module and do this Right?
> 
>   klen_len = len('K %d\n' % klen)
> 
> Very clear, and no funny math going on.

And on top of that, we can save & use the formatted string when the
time comes to print the data, so we don't waste it...

Will do, thanks for the suggestion.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org