You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/16 18:19:28 UTC
[GitHub] [arrow] assignUser opened a new pull request, #13167: MINOR: [CI] Fix centos cmake path
assignUser opened a new pull request, #13167:
URL: https://github.com/apache/arrow/pull/13167
cmake file naming convention changed sometime between 3.18 and 3.23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs merged pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
kszucs merged PR #13167:
URL: https://github.com/apache/arrow/pull/13167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13167:
URL: https://github.com/apache/arrow/pull/13167#issuecomment-1128007678
Not any merged ones but the workflow for [R nightly builds](https://github.com/assignUser/test-repo-a/runs/6457555112?check_suite_focus=true#step:6:363) I am currently working on fails due this if I use `-r https://github.com/apache/arrow -b master` or if I use my fork it fails in autobrew due to the ref not existing in this repo. So more of a future fix :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13167:
URL: https://github.com/apache/arrow/pull/13167#issuecomment-1127992865
@kszucs quick review please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a diff in pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13167:
URL: https://github.com/apache/arrow/pull/13167#discussion_r874048549
##########
ci/docker/centos-7-cpp.dockerfile:
##########
@@ -30,7 +30,7 @@ RUN yum install -y \
ARG cmake=3.23.1
RUN wget -nv -O - https://github.com/Kitware/CMake/releases/download/v${cmake}/cmake-${cmake}-Linux-x86_64.tar.gz | tar -xzf - -C /opt
Review Comment:
@assignUser could you perhaps update the install step to place it under `/opt/cmake-${cmake}` instead, so the path is always correct regardless the cmake version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13167:
URL: https://github.com/apache/arrow/pull/13167#discussion_r874064518
##########
ci/docker/centos-7-cpp.dockerfile:
##########
@@ -30,7 +30,7 @@ RUN yum install -y \
ARG cmake=3.23.1
RUN wget -nv -O - https://github.com/Kitware/CMake/releases/download/v${cmake}/cmake-${cmake}-Linux-x86_64.tar.gz | tar -xzf - -C /opt
Review Comment:
Thanks for the suggestion, tested it successfully here: https://github.com/assignUser/test-repo-a/runs/6458346977?check_suite_focus=true#step:6:392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a diff in pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13167:
URL: https://github.com/apache/arrow/pull/13167#discussion_r874048549
##########
ci/docker/centos-7-cpp.dockerfile:
##########
@@ -30,7 +30,7 @@ RUN yum install -y \
ARG cmake=3.23.1
RUN wget -nv -O - https://github.com/Kitware/CMake/releases/download/v${cmake}/cmake-${cmake}-Linux-x86_64.tar.gz | tar -xzf - -C /opt
Review Comment:
@assignUser could you perhaps update the install setup to place it under `/opt/cmake-${cmake}` instead, so the path is always correct regardless the cmake version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #13167: MINOR: [CI] Fix centos cmake path
Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #13167:
URL: https://github.com/apache/arrow/pull/13167#issuecomment-1128000547
Does this fix any particular build failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org