[GitHub] [beam] tysonjh commented on a change in pull request #13656: [BEAM-10961] Enabled strict dependency on Direct Java runner

[GitBox <gi...@apache.org>]

tysonjh commented on a change in pull request #13656:
URL: https://github.com/apache/beam/pull/13656#discussion_r560416204



##########
File path: runners/direct-java/build.gradle
##########
@@ -72,17 +73,12 @@ dependencies {
   shadow library.java.vendored_grpc_1_26_0
   shadow library.java.joda_time
   shadow library.java.slf4j_api
-  shadow library.java.args4j
+  compile library.java.jackson_databind

Review comment:
       Is a `compile` time dependency required here, or can this be shadowed?

##########
File path: runners/direct-java/build.gradle
##########
@@ -93,6 +89,10 @@ dependencies {
   validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
   validatesRunner project(path: project.path, configuration: "shadow")
   validatesRunner project(path: project.path, configuration: "shadowTest")
+  //runtime dependencies of the tests
+  permitUnusedDeclared library.java.vendored_grpc_1_26_0
+  permitUnusedDeclared project(":runners:java-fn-execution")
+  permitUnusedDeclared project(":sdks:java:fn-execution")

Review comment:
       This seems like a heavyweight approach. Could you elaborate on why these are permitted? Perhaps providing some evidence of the failures would help determine a more nuanced approach.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org