[GitHub] [incubator-pinot] kishoreg commented on issue #4388: Adding support for Map type fields

[GitBox <gi...@apache.org>]

kishoreg commented on issue #4388: Adding support for Map type fields
URL: https://github.com/apache/incubator-pinot/pull/4388#issuecomment-514069100
 
 
   > 1. Please open issues for things not handled in the PR.
   Will create issues for
   - supporting map type syntax map['key']. This will be handled automatically when we start using calcite.
   Anything else you can think of?
   > 2. The __KEYS and __VALUES columns have specific semantics in the code, however, they are stored as MV columns. Are there any issues in allowing these columns to be treated as regular MV columns when the queries are not of the form specified in the PR description?
   Not really.
   > 3. Would be good to add a real world example that this feature can help solve, in the description.
   - will update the docs. I think the need for map type is pretty obvious.  classic cases - tags/labels, sparse dimensions, etc.
   
   
   -
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org