You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/27 14:45:44 UTC

[GitHub] [hudi] nsivabalan opened a new pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

nsivabalan opened a new pull request #4919:
URL: https://github.com/apache/hudi/pull/4919


   ## What is the purpose of the pull request
   
   With latest addition of TypedProperties in HoodieTableConfig, we ran into issues w/ kafka key and value serializer types in properties. Apparently value type was class and hence when getting string values, it returns null values while populating TypedProperties. Fixed all such instances of key.serializer and value.serializer instantiations. 
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053602113


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6361",
       "triggerID" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a292f431368fb83282bc8e285608b7e94d2c959e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6361) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053578191


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a292f431368fb83282bc8e285608b7e94d2c959e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053578191


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a292f431368fb83282bc8e285608b7e94d2c959e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053603205


   @codope : went ahead w/ merging since this is critical. If you have any feedback, will address in a follow up PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053578936


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6361",
       "triggerID" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a292f431368fb83282bc8e285608b7e94d2c959e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6361) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053578936


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6361",
       "triggerID" : "a292f431368fb83282bc8e285608b7e94d2c959e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a292f431368fb83282bc8e285608b7e94d2c959e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6361) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4919:
URL: https://github.com/apache/hudi/pull/4919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on pull request #4919: [HUDI-3521] Fixing kafka key and value serializer value type from class to string

Posted by GitBox <gi...@apache.org>.
codope commented on pull request #4919:
URL: https://github.com/apache/hudi/pull/4919#issuecomment-1053856892


   Looks good to me. I was just waiting for CI success 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org