You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/08 17:27:04 UTC
[jira] [Commented] (CLIMATE-489) Improve
dataset_processor.subset()'s ValueError Message
[ https://issues.apache.org/jira/browse/CLIMATE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055041#comment-14055041 ]
ASF GitHub Bot commented on CLIMATE-489:
----------------------------------------
GitHub user cgoodale opened a pull request:
https://github.com/apache/climate/pull/87
CLIMATE-489 Improve Subset Bounds Error Message
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cgoodale/climate CLIMATE-489
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 16a226ac192332743fa0dcf3cdc85e496219665b
Author: cgoodale <si...@gmail.com>
Date: 2014-07-08T14:39:45Z
Add better subset error reporting
* Using a try/expect block instead of Boolean comparison
* Updated the docstring on subset function
* Building up a list of errors to support multiple errors in one pass
commit b49042db5fd6dac5a11b413c65e472acd04364b4
Author: cgoodale <si...@gmail.com>
Date: 2014-07-08T14:57:49Z
Remove extra Try/Except block
----
> Improve dataset_processor.subset()'s ValueError Message
> -------------------------------------------------------
>
> Key: CLIMATE-489
> URL: https://issues.apache.org/jira/browse/CLIMATE-489
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: regridding/data processing
> Affects Versions: 0.3-incubating
> Environment: *nix
> Reporter: Cameron Goodale
> Assignee: Cameron Goodale
> Priority: Minor
> Fix For: 0.4
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> While developing the Model Ensemble example I encountered two datasets that don't align perfectly. So when I tried to use the extent of one dataset to subset the other I was greeted with this error message:
> {code}
> ValueError: dataset_processor.subset received a subregion that is not completely within the bounds of the target dataset.
> {code}
> The trouble I then ran into is how to track down which of the 6 subsetting attributes did not align.
> Plan of attack:
> ----
> Update _are_bounds_contained_by_dataset to raise an error when any of the 6 comparisons are found to be invalid, and include a message relaying what attribute(s) are in error.
> Use this new error message to finally raise the error to the end user so they can adjust the bounds accordingly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)