You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/12/17 13:03:24 UTC

[GitHub] [unomi] Taybou opened a new pull request #228: UNOMI-409 add .gitignore

Taybou opened a new pull request #228:
URL: https://github.com/apache/unomi/pull/228


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber commented on a change in pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #228:
URL: https://github.com/apache/unomi/pull/228#discussion_r551949618



##########
File path: extensions/web-tracker/javascript/.gitignore
##########
@@ -0,0 +1 @@
+dist

Review comment:
       I guess so, I'm not an expert at NPM packaging, would that make sense from that point of view?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber merged pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
sergehuber merged pull request #228:
URL: https://github.com/apache/unomi/pull/228


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] Taybou commented on a change in pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #228:
URL: https://github.com/apache/unomi/pull/228#discussion_r551947892



##########
File path: extensions/web-tracker/javascript/.gitignore
##########
@@ -0,0 +1 @@
+dist

Review comment:
       yes, in this case, we can move snippet.min.js && snippet.min.js.map into dist, is it okay? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber commented on pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #228:
URL: https://github.com/apache/unomi/pull/228#issuecomment-755141930


   Thanks for the changes, looks good to me will merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] Taybou commented on a change in pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #228:
URL: https://github.com/apache/unomi/pull/228#discussion_r551947892



##########
File path: extensions/web-tracker/javascript/.gitignore
##########
@@ -0,0 +1 @@
+dist

Review comment:
       yes, in this case, we can move snippet.min.js && snippet.min.js.map into /dist, is it okay? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] Taybou commented on a change in pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #228:
URL: https://github.com/apache/unomi/pull/228#discussion_r551951867



##########
File path: extensions/web-tracker/javascript/.gitignore
##########
@@ -0,0 +1 @@
+dist

Review comment:
       yes, I'll handle it, thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber commented on a change in pull request #228: UNOMI-409 add .gitignore to unomi-web-tracker

Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #228:
URL: https://github.com/apache/unomi/pull/228#discussion_r551935426



##########
File path: extensions/web-tracker/javascript/.gitignore
##########
@@ -0,0 +1 @@
+dist

Review comment:
       I think we should ignore the snippet.min.js and the snippet.min.js.map instead of committing them WDYT ? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org