[GitHub] [superset] AAfghahi commented on a change in pull request #15236: fix: do not use Marshmallow validation in partial params validation

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #15236:
URL: https://github.com/apache/superset/pull/15236#discussion_r654516181



##########
File path: superset/db_engine_specs/base.py
##########
@@ -1445,7 +1445,19 @@ def validate_parameters(
         port = parameters.get("port", None)
         if not port:
             return errors
-        if not is_port_open(host, port):
+        if not (isinstance(port, int) and 0 <= port < 2 ** 16):

Review comment:
       do we stringify the json? @hughhhh 
   
   ![Screen Shot 2021-06-18 at 11 18 45 AM](https://user-images.githubusercontent.com/48933336/122583419-34055a00-d027-11eb-8d97-dc68702480a0.png)
   
   ![Screen Shot 2021-06-18 at 11 20 24 AM](https://user-images.githubusercontent.com/48933336/122583430-37004a80-d027-11eb-8707-c49375f80e2f.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org