You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/23 23:03:47 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #15511: Finish refactor of DAG resource name helper

jedcunningham commented on a change in pull request #15511:
URL: https://github.com/apache/airflow/pull/15511#discussion_r619534369



##########
File path: airflow/security/permissions.py
##########
@@ -63,8 +63,8 @@
 DAG_PERMS = {ACTION_CAN_READ, ACTION_CAN_EDIT}
 
 
-def permission_name_for_dag(dag_id):
-    """Returns the permission name for a DAG id."""
+def resource_name_for_dag(dag_id):

Review comment:
       This is the _right_ name for this, pretty sure. Input @jhtimmins?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org