You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Jens Grivolla (JIRA)" <ji...@apache.org> on 2009/02/18 16:37:02 UTC
[jira] Created: (MAHOUT-107) make MySQLJDBCDataModel not final
make MySQLJDBCDataModel not final
---------------------------------
Key: MAHOUT-107
URL: https://issues.apache.org/jira/browse/MAHOUT-107
Project: Mahout
Issue Type: Improvement
Components: Collaborative Filtering
Reporter: Jens Grivolla
Priority: Minor
Is there a particular reason for MySQLJDBCDataModel being final?
I am using a derived class to incorporate additional information about the items and users (overriding buildItem etc.) and had to change my version of MySQLJDBCDataModel to be able to extend it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-107) make MySQLJDBCDataModel not final
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-107.
------------------------------
Resolution: Fixed
Fix Version/s: 0.2
OK I made it non-final but also loosened other restrictions, so you could also subclass AbstractJDBCDataModel, and override more of its methods.
> make MySQLJDBCDataModel not final
> ---------------------------------
>
> Key: MAHOUT-107
> URL: https://issues.apache.org/jira/browse/MAHOUT-107
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Jens Grivolla
> Priority: Minor
> Fix For: 0.2
>
>
> Is there a particular reason for MySQLJDBCDataModel being final?
> I am using a derived class to incorporate additional information about the items and users (overriding buildItem etc.) and had to change my version of MySQLJDBCDataModel to be able to extend it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-107) make MySQLJDBCDataModel not final
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674664#action_12674664 ]
Sean Owen commented on MAHOUT-107:
----------------------------------
I suppose just because I hadn't necessarily intended it to be extended, but it is not out of the question.
I don't mind just making it non-final. But I'd also like to know more about how you extend it so perhaps I can accommodate that more directly and effectively in the classes.
> make MySQLJDBCDataModel not final
> ---------------------------------
>
> Key: MAHOUT-107
> URL: https://issues.apache.org/jira/browse/MAHOUT-107
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Jens Grivolla
> Priority: Minor
>
> Is there a particular reason for MySQLJDBCDataModel being final?
> I am using a derived class to incorporate additional information about the items and users (overriding buildItem etc.) and had to change my version of MySQLJDBCDataModel to be able to extend it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-107) make MySQLJDBCDataModel not final
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674985#action_12674985 ]
Sean Owen commented on MAHOUT-107:
----------------------------------
Actually, why do you extend this class? I looked again, it is indeed just "filling in the blanks" in AbstractJDBCDataModel. If you want to use different SQL, just do the same thing -- copy and paste this class even. I am certainly open to enabling new hooks to customize the behavior of these classes if you'll describe what you're trying to do.
> make MySQLJDBCDataModel not final
> ---------------------------------
>
> Key: MAHOUT-107
> URL: https://issues.apache.org/jira/browse/MAHOUT-107
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Jens Grivolla
> Priority: Minor
>
> Is there a particular reason for MySQLJDBCDataModel being final?
> I am using a derived class to incorporate additional information about the items and users (overriding buildItem etc.) and had to change my version of MySQLJDBCDataModel to be able to extend it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-107) make MySQLJDBCDataModel not final
Posted by "Jens Grivolla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675975#action_12675975 ]
Jens Grivolla commented on MAHOUT-107:
--------------------------------------
In order to build a MySQLJDBCDiffStorage my DataModel needs to be a MySQLJDBCDataModel. If I just subclass AbstractJDBCDataModel this does not work.
I do however need to change buildItem in order to have item names etc., so I can't use MySQLJDBCDataModel, afaics. I have a table containing a list of items with item details and want buildItem(id) to use that information instead of just returning a GenericItem.
> make MySQLJDBCDataModel not final
> ---------------------------------
>
> Key: MAHOUT-107
> URL: https://issues.apache.org/jira/browse/MAHOUT-107
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Jens Grivolla
> Priority: Minor
>
> Is there a particular reason for MySQLJDBCDataModel being final?
> I am using a derived class to incorporate additional information about the items and users (overriding buildItem etc.) and had to change my version of MySQLJDBCDataModel to be able to extend it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.