[jira] Commented: (DERBY-1224) Remove unused variables in DatabaseMetaData

["Bryan Pendleton (JIRA)" <de...@db.apache.org>]

    [ http://issues.apache.org/jira/browse/DERBY-1224?page=comments#action_12374836 ] 

Bryan Pendleton commented on DERBY-1224:
----------------------------------------

I'm all in favor of removing unused code. I think this is a good change.

> Remove unused variables in DatabaseMetaData
> -------------------------------------------
>
>          Key: DERBY-1224
>          URL: http://issues.apache.org/jira/browse/DERBY-1224
>      Project: Derby
>         Type: Improvement

>   Components: JDBC, Network Client, Performance
>     Versions: 10.2.0.0
>     Reporter: Knut Anders Hatlen
>     Assignee: Knut Anders Hatlen
>     Priority: Minor
>  Attachments: derby-1224-v1.diff, derby-1224-v1.stat
>
> org.apache.derby.client.am.DatabaseMetaData has a number of instance
> variables which don't seem to have any purpose:
>   lastGetColumnPrivilegesResultSet_
>   lastGetColumnsResultSet_
>   lastGetForeignKeysResultSet_
>   lastGetPrimaryKeysResultSet_
>   lastGetProcedureColumnsResultSet_
>   lastGetProceduresResultSet_
>   lastGetSpecialColumnsResultSet_
>   lastGetStatisticsResultSet_
>   lastGetTablePrivilegesResultSet_
>   lastGetTablesResultSet_
>   lastGetUDTsResultSet_
>   lastGetTypeInfoResultSet_
>   lastGetAttrResultSet_
>   lastGetSuperTypesResultSet_
>   lastGetSuperTablesResultSet_
> Each lastGetXXXResultSet_ variable is set when the corresponding
> getXXX method is invoked. However, the variables are never read, so
> they could just as well be removed. Removing them will reduce the
> memory footprint.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira