You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/10/05 23:58:10 UTC
[GitHub] [tinkerpop] cole-bq opened a new pull request, #1821: TINKERPOP-2808 Improving ARM Compatibility
cole-bq opened a new pull request, #1821:
URL: https://github.com/apache/tinkerpop/pull/1821
https://issues.apache.org/jira/browse/TINKERPOP-2808
Compatibility fixes for ARM based Macs
Updated base images for gremlin-server and gremlin-console docker images to support arm64:
The previously used adopt openjdk11 alpine linux image does not support arm64. In fact none of the major openjdk distributions maintain a jdk11 alpine image for arm64. Changed base image to alpine and installed oracle openjdk 11. Oracle openjdk 11 was chosen as it is already maintained in the APK community repository.
Added jansi as an explicit dependency of gremlin-console. Previously it was a dependency of jline which itself is a dependency of groovy. The console is able to run just fine on x64 architectures but it cannot run on arm JDK's without importing Jansi directly. This change resolves [TINKERPOP-2584](https://issues.apache.org/jira/browse/TINKERPOP-2584) at least for ARM Macs.
Updated dev docs with instructions to configure docker desktop for better performance on apple silicon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] cole-bq commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
cole-bq commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1270739083
> Please provide size of Gremlin Server docker image.
>
> everything else is fine, VOTE +1
New image size is 372 MB, essentially the same size as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1269220318
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1821](https://codecov.io/gh/apache/tinkerpop/pull/1821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4453649) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/81688b6b55e555c6d74a5ff8aeb43b87fac539ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81688b6) will **decrease** coverage by `5.85%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1821 +/- ##
=============================================
- Coverage 69.43% 63.58% -5.86%
=============================================
Files 861 23 -838
Lines 40858 3636 -37222
Branches 5384 0 -5384
=============================================
- Hits 28371 2312 -26059
+ Misses 10584 1145 -9439
+ Partials 1903 179 -1724
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...remlin/process/traversal/step/filter/NoneStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL2ZpbHRlci9Ob25lU3RlcC5qYXZh) | | |
| [...tinkergraph/process/computer/TinkerMapEmitter.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy9jb21wdXRlci9UaW5rZXJNYXBFbWl0dGVyLmphdmE=) | | |
| [...kergraph/process/computer/TinkerGraphComputer.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy9jb21wdXRlci9UaW5rZXJHcmFwaENvbXB1dGVyLmphdmE=) | | |
| [...ache/tinkerpop/gremlin/server/handler/Session.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL1Nlc3Npb24uamF2YQ==) | | |
| [.../tinkerpop/gremlin/process/traversal/Bindings.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9CaW5kaW5ncy5qYXZh) | | |
| [...erpop/gremlin/process/traversal/util/PathUtil.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL1BhdGhVdGlsLmphdmE=) | | |
| [...p/gremlin/process/traversal/step/ByModulating.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL0J5TW9kdWxhdGluZy5qYXZh) | | |
| [...mlin/driver/ser/GraphSONMessageSerializerV3d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9zZXIvR3JhcGhTT05NZXNzYWdlU2VyaWFsaXplclYzZDAuamF2YQ==) | | |
| [...tructure/io/binary/types/SingleTypeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL1NpbmdsZVR5cGVTZXJpYWxpemVyLmphdmE=) | | |
| [...structure/io/graphson/JavaTimeSerializersV3d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vZ3JhcGhzb24vSmF2YVRpbWVTZXJpYWxpemVyc1YzZDAuamF2YQ==) | | |
| ... and [828 more](https://codecov.io/gh/apache/tinkerpop/pull/1821/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] cole-bq commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
cole-bq commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1270896699
> nice - people have definitely been asking for this.
>
> > Oracle openjdk 11 was chosen as it is already maintained in the APK community repository
>
> it sounded like there wasn't based on what you wrote in the description of the PR, but i'll ask again...was there any other option besides Oracle openjdk?
>
> I once tried to change our docker image to use what i use on my system: https://sdkman.io/ which would then let us easy install whatever jdk, maven, etc. that we wanted. love that thing. i can't remember what problems I had but it never worked right. that might be a nice little thing to do if it's easy. not saying it necessarily needs to be done on this PR, but I guess I'd thought most devs moved on from Oracle JDK at this point and i thought temurin/corretto were what folks gravitated to.
Yes Oracle openjdk is the only option in the apk repository. I made a trivial attempt at using sdkman for the image but I ran into problems with it. If there is enough interest in using temurin or corretto I could look into it further but for now Oracle is the easiest and simplest option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1271810313
VOTE +1.
Thanks Cole!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1270668254
Please provide size of Gremlin Server docker image.
everything else is fine, VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1271418381
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821#issuecomment-1270769955
nice - people have definitely been asking for this.
> Oracle openjdk 11 was chosen as it is already maintained in the APK community repository
it sounded like there wasn't based on what you wrote in the description of the PR, but i'll ask again...was there any other option besides Oracle openjdk?
I once tried to change our docker image to use what i use on my system: https://sdkman.io/ which would then let us easy install whatever jdk, maven, etc. that we wanted. love that thing. i can't remember what problems I had but it never worked right. that might be a nice little thing to do if it's easy. not saying it necessarily needs to be done on this PR, but I guess I'd thought most devs moved on from Oracle JDK at this point and i thought temurin/corretto were what folks gravitated to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk merged pull request #1821: TINKERPOP-2808 Improving ARM Compatibility
Posted by GitBox <gi...@apache.org>.
vkagamlyk merged PR #1821:
URL: https://github.com/apache/tinkerpop/pull/1821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org