You are viewing a plain text version of this content. The canonical link for it is here.
Posted to muse-dev@ws.apache.org by "Jose Antonio (JIRA)" <ji...@apache.org> on 2007/03/21 13:15:32 UTC

[jira] Created: (MUSE-214) XML element name could lead to invalid operation generation.

XML element name could lead to invalid operation generation.
------------------------------------------------------------

                 Key: MUSE-214
                 URL: https://issues.apache.org/jira/browse/MUSE-214
             Project: Muse
          Issue Type: Bug
          Components: Tooling - Code Generation
    Affects Versions: 2.2.0
         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
            Reporter: Jose Antonio
         Assigned To: Dan Jemiolo


Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
public void this-is-valid() throws Exception

Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:

public void this_is_valid()

I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482887 ] 

Dan Jemiolo commented on MUSE-214:
----------------------------------

Talked to Andrew some more and it looks like his solution will cover the cases presented here without doing method mapping in the descriptor. We'll work together to get that going in 2.3.

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Vinh Nguyen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482863 ] 

Vinh Nguyen commented on MUSE-214:
----------------------------------

Currently, when Muse needs to invoke an operation, it scans the resource's capabilities and calls the one that has a method matching the name of the operation.  I think this error prone because of the different scenarios in which operations are named.  Also, two capabilities might have methods with the same name but we can't control which capability Muse should call for a given operation.

I think an easy way is to add entries in muse.xml that allows the developer to explicitly map a wsdl operation name to the actual Java method name. Normally, a developer should keep them the same, but they should also have the flexibility to control this. This way, Muse doesn't have to second guess what the java method name should be given the wsdl operation name, and wsdl2java doesn't have to be precisely correct when trying to generate the stub classes. It might not be possible to have wsdl2java cover all the different operation naming scenarios.

For example, the muse.xml could look like this:
    <resource-type>
        <context-path>SimpleResource</context-path>
        <capability>
            <capability-uri>http://ws.apache.org/muse/test/simple/first</capability-uri>
            <java-capability-class>org.apache.muse.test.simple.first.FirstCapabilityImpl
                <capability-operation-mapping>
                    <wsdl-operation>Get</wsdl-operation>
                    <java-method>get</java-method>
                </capability-operation-mapping>
                <capability-operation-mapping>
                    <!-- Here, wsdl2java would generate an invalid method name because they can't start with numbers. So map to a correct name. -->
                    <wsdl-operation>123Operation</wsdl-operation>
                    <java-method>get123Operation</java-method>
                </capability-operation-mapping>
            </java-capability-class>
        </capability>
    </resource-type>



> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Jose Antonio (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482882 ] 

Jose Antonio commented on MUSE-214:
-----------------------------------

The problem is that sometimes you cannot modify certain elements. For example, I'm trying to integrate WSDM with WS-CAF so, for some operations, messages have to be compliant with WS-CAF specification. It happens that this specification has two elements with the same name in different namespaces and I have to expect that elements exactly as they are in the xsd files. I can regenerate the WSDL as it's not normative, but not the xsd files because they define the messages format. That could be even applicable to specifications in that you cannot modify even the wsdl involved. So for that strange cases there could be a method to specifiy a route from a message to an operation, it doesn't matter if it's more or less complicated as it's going to be more the exception than the norm, but having a convention could lead to Muse not being integrable with other WS-* specifications even if they can interact with WSDM perfectly.

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482799 ] 

Dan Jemiolo commented on MUSE-214:
----------------------------------

I think this is more than a wsdl2java issue - the runtime also has to allow for the - to _ change. So, right now, I don't think there's a workaround, since you can't just change the wsdl2java output. This relates to MUSE-208 and the fix outlined for that issue. We have to change the code in SimpleResourceDescriptor.createMessageHandlers( ) so that it replaces - with _ at the time the WSDL is parsed at startup.


> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Updated: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Jemiolo updated MUSE-214:
-----------------------------

    Fix Version/s: 2.3.0
         Priority: Minor  (was: Major)

scheduling for 2.3

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Jose Antonio (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482854 ] 

Jose Antonio commented on MUSE-214:
-----------------------------------

Also there's a problem with how methods are generated in the stub. I have the following operations:


<wsdl:message name="CompletedMessage">
	<wsdl:part element="wsctx:completed" name="content"/>
</wsdl:message>
<wsdl:operation name="completed">
	<wsdl:input 
		wsa:Action="http://docs.oasis-open.org/schemas/2005/10/wsctx/completed"
		message="tns:CompletedMessage"/>
</wsdl:operation>

and

<wsdl:message name="CompensatorCompletedMessage">
	<wsdl:part name="content" element="lra:completed"/>
</wsdl:message>
<wsdl:operation name="CompensatorCompleted">
	<wsdl:input 
		wsa:Action="http://www.webservicestransactions.org/schemas/wstxm/tx-lra/2003/03/completed"
		message="tns:CompensatorCompletedMessage"/>
</wsdl:operation>

They both map to the completed() operation but there's no problem in the server as both elements (lra:completed and wsctx:completed) are in different namespaces and so, they are generated in different capabilities. The problem is with the stub, as all operations goes to the same class, both of them are called completed() and so, there is a collision. I had to change the name by hand. Using the wsdl:operation name for method names is a better way to deal with this, as they are in the same namespace and they must be different.

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Andrew Eberbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482837 ] 

Andrew Eberbach commented on MUSE-214:
--------------------------------------

One approach could be to define a standard utility method that will take a proposed name and perform a check and mapping. Some names shouldn't be allowed (such as names that are the same as names in the Capability or Client super classes) in which case this method would return null or throw an exception. For the other names, there would be a consistent way to remove or replace offending characters so that we conform to the Java syntax.  Finally there should be some logic that keeps track of unintentional collisions such as my-function and my?function being both mapped ot my_function.

This utility method would wrap the existing Method object creation code in wsdl2java and the code that does the translation in the runtime. 

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Jose Antonio (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482792 ] 

Jose Antonio commented on MUSE-214:
-----------------------------------

While this gets fixed, is there a way for me to implement a my_custom_process() method in my capability and get it called when a <my-custom-process> element is received?

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Vinh Nguyen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482890 ] 

Vinh Nguyen commented on MUSE-214:
----------------------------------

I agree with you Dan. My suggestion does add flexibility but makes the muse.xml more heavyweight. I guess this whole approach is whether the configuration work should be done at runtime (via the muse.xml configurations) or pushed up to design time (via changing the wsdl/xsds).

Looks like the config-based approach is what JAX-RPC is doing, which makes work easier for designers but harder for developers.

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Andrew Eberbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482867 ] 

Andrew Eberbach commented on MUSE-214:
--------------------------------------

Yes, I agree with the wsdl:operation suggestion and we already have a JIRA item open for it (MUSE-208). 

I think the namespace collision mapping can be handled by taking into account the namespace of the incoming element. We'd of course use the maps for the built-in types, but for types that are generated with wsdl2java the namespace URI of the element == the capability URI. This way we can immediately go to the right capability and look for the method.

> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org


[jira] Commented: (MUSE-214) XML element name could lead to invalid operation generation.

Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MUSE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482873 ] 

Dan Jemiolo commented on MUSE-214:
----------------------------------

Before everyone gets excited about the ability to map operation names to any kind of method available, I'd encourage you to stop and compare the current Muse descriptor to some other, past descriptors that have been used for similar tasks. The current Muse descriptor is already, in my opinion, larger than it should be - I'd like to be able to rely more on convention and less on config parameters. But we can't do anything about what's already there; it's important that we try and keep the descriptor as simple as possible so that it does not turn into the JAX-RPC mapping file.

The JAX-RPC mapping file is a standard descriptor described by the JAX-RPC JSR. Its schema is here:

    http://java.sun.com/xml/ns/j2ee/j2ee_jaxrpc_mapping_1_1.xsd

At the bottom of this comment is an example JAX-RPC mapping file from an old project we had that ran on WebSphere. It only defines the four WSRP operations and two WSRL operations, and it has all of the flexibility that has described in this issue so far. It's also known, inside IBM, as "the file that no human could create by hand". To me, that is a huge red flag. The Muse descriptor is no nirvana either, but it's still creatable without the magic of Rational Application Developer, etc.

It looks to me like we're headed down the road of the JAX-RPC mapping file, and I want to be sure we don't do so lightly. Muse does not allow operation overloading right now because that is not compliant with the WS-I Basic Profile. This means that a capability should not have two methods with the same name. The problem of two capabilities having the same method after code gen seems like a design time problem to me - would it not be clearer to change your own WSDLs/XSDs to accomodate any WSDLs/XSDs that you're importing and cannot change? It seems like we will end up adding a lot of infrastructure and schema in order to allow for a confusing interface design. This must be balanced with the need to meet the original goals of the project, among them, making WS-* more accessible to the average programmer.


Sample JAX-RPC mapping file for just WSRP and WSRL:


<?xml version="1.0" encoding="UTF-8"?>
<java-wsdl-mapping xmlns="http://java.sun.com/xml/ns/j2ee"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.1"
	xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://www.ibm.com/webservices/xsd/j2ee_jaxrpc_mapping_1_1.xsd">
	<package-mapping>
		<package-type>com.ibm.cowbell.deploy.websphere</package-type>
		<namespaceURI>
			http://websphere.deploy.cowbell.ibm.com
		</namespaceURI>
	</package-mapping>
	<java-xml-type-mapping>
		<java-type>org.w3c.dom.Element</java-type>
		<root-type-qname xmlns:rtq="http://xml.apache.org/xml-soap">
			rtq:Element
		</root-type-qname>
		<qname-scope>complexType</qname-scope>
	</java-xml-type-mapping>
	<java-xml-type-mapping>
		<java-type>javax.xml.soap.SOAPElement</java-type>
		<root-type-qname
			xmlns:rtq="http://websphere.ibm.com/webservices/">
			rtq:SOAPElement
		</root-type-qname>
		<qname-scope>complexType</qname-scope>
	</java-xml-type-mapping>
	<java-xml-type-mapping>
		<java-type>java.lang.Object</java-type>
		<root-type-qname xmlns:rtq="http://www.w3.org/2001/XMLSchema">
			rtq:anyType
		</root-type-qname>
		<qname-scope>simpleType</qname-scope>
	</java-xml-type-mapping>
	<service-interface-mapping>
		<service-interface>
			com.ibm.cowbell.deploy.websphere.WebSphereTouchpointServiceService
		</service-interface>
		<wsdl-service-name
			xmlns:sim="http://websphere.deploy.cowbell.ibm.com">
			sim:WebSphereTouchpointServiceService
		</wsdl-service-name>
		<port-mapping>
			<port-name>WebSphereTouchpointService</port-name>
			<java-port-name>WebSphereTouchpointService</java-port-name>
		</port-mapping>
	</service-interface-mapping>
	<service-endpoint-interface-mapping>
		<service-endpoint-interface>
			com.ibm.cowbell.deploy.websphere.WebSphereTouchpointService
		</service-endpoint-interface>
		<wsdl-port-type
			xmlns:seimwpt="http://websphere.deploy.cowbell.ibm.com">
			seimwpt:WebSphereTouchpointService
		</wsdl-port-type>
		<wsdl-binding
			xmlns:seimwb="http://websphere.deploy.cowbell.ibm.com">
			seimwb:WebSphereTouchpointServiceSoapBinding
		</wsdl-binding>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>GetResourceProperty</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:GetResourcePropertyRequest
					</wsdl-message>
					<wsdl-message-part-name>
						GetResourceProperty
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:GetResourcePropertyResponse
				</wsdl-message>
				<wsdl-message-part-name>
					GetResourcePropertyResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>
				GetMultipleResourceProperties
			</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:GetMultipleResourcePropertiesRequest
					</wsdl-message>
					<wsdl-message-part-name>
						GetMultipleResourceProperties
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:GetMultipleResourcePropertiesResponse
				</wsdl-message>
				<wsdl-message-part-name>
					GetMultipleResourcePropertiesResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>QueryResourceProperties</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:QueryResourcePropertiesRequest
					</wsdl-message>
					<wsdl-message-part-name>
						QueryResourceProperties
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:QueryResourcePropertiesResponse
				</wsdl-message>
				<wsdl-message-part-name>
					QueryResourcePropertiesResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>SetResourceProperties</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:SetResourcePropertiesRequest
					</wsdl-message>
					<wsdl-message-part-name>
						SetResourceProperties
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:SetResourcePropertiesResponse
				</wsdl-message>
				<wsdl-message-part-name>
					SetResourcePropertiesResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>Destroy</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:DestroyRequest
					</wsdl-message>
					<wsdl-message-part-name>
						Destroy
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:DestroyResponse
				</wsdl-message>
				<wsdl-message-part-name>
					DestroyResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>SetTerminationTime</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:SetTerminationTimeRequest
					</wsdl-message>
					<wsdl-message-part-name>
						SetTerminationTime
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:SetTerminationTimeResponse
				</wsdl-message>
				<wsdl-message-part-name>
					SetTerminationTimeResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>

		<service-endpoint-method-mapping>
			<java-method-name>handleRequest</java-method-name>
			<wsdl-operation>Create</wsdl-operation>
			<wrapped-element></wrapped-element>
			<method-param-parts-mapping>
				<param-position>0</param-position>
				<param-type>org.w3c.dom.Element</param-type>
				<wsdl-message-mapping>
					<wsdl-message
						xmlns:mppm="http://websphere.deploy.cowbell.ibm.com">
						mppm:CreateRequest
					</wsdl-message>
					<wsdl-message-part-name>
						Create
					</wsdl-message-part-name>
					<parameter-mode>IN</parameter-mode>
				</wsdl-message-mapping>
			</method-param-parts-mapping>
			<wsdl-return-value-mapping>
				<method-return-value>
					org.w3c.dom.Element
				</method-return-value>
				<wsdl-message
					xmlns:wrvm="http://websphere.deploy.cowbell.ibm.com">
					wrvm:CreateResponse
				</wsdl-message>
				<wsdl-message-part-name>
					CreateResponse
				</wsdl-message-part-name>
			</wsdl-return-value-mapping>
		</service-endpoint-method-mapping>


	</service-endpoint-interface-mapping>
</java-wsdl-mapping>



> XML element name could lead to invalid operation generation.
> ------------------------------------------------------------
>
>                 Key: MUSE-214
>                 URL: https://issues.apache.org/jira/browse/MUSE-214
>             Project: Muse
>          Issue Type: Bug
>          Components: Tooling - Code Generation
>    Affects Versions: 2.2.0
>         Environment: Ubuntu Edgy 6.10, JDK 1.5.0
>            Reporter: Jose Antonio
>         Assigned To: Dan Jemiolo
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Some valid elements named as <element name="this-is-valid"> could lead to the generation of invalid function names like
> public void this-is-valid() throws Exception
> Which is not a valid java function name. When dealing with such names, upper dashes should be substituted with lower dashes so it generates a valid name:
> public void this_is_valid()
> I've found this while dealing with a wsdl that I have no control over it, so I cannot change the element's format because it's from a server that's deployed and is going to invoke me with that message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org