[GitHub] [yunikorn-release] elihschiff commented on a diff in pull request #116: [YUNIKORN-1371] Migrate to new ConfigMap configuration

[GitBox <gi...@apache.org>]

elihschiff commented on code in PR #116:
URL: https://github.com/apache/yunikorn-release/pull/116#discussion_r1035307098


##########
helm-charts/yunikorn/templates/deployment.yaml:
##########
@@ -24,7 +24,7 @@ metadata:
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
 spec:
-  replicas: {{ .Values.replicaCount }}
+  replicas: 1

Review Comment:
   Hi @craigcondit 
   
   I am just curious about the decision on why the replicas value is now hard coded. Does this feature no longer work with values > 1? Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org