You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "MangerLe (via GitHub)" <gi...@apache.org> on 2023/04/18 03:47:56 UTC
[GitHub] [dubbo] MangerLe opened a new issue, #12117: A question about AdaptiveLoadBalance
MangerLe opened a new issue, #12117:
URL: https://github.com/apache/dubbo/issues/12117
In this judgment, is it only necessary to judge the case of equal, not the case of greater than?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #12117: A question about AdaptiveLoadBalance
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #12117:
URL: https://github.com/apache/dubbo/issues/12117#issuecomment-1515918357
@ningboliu PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] ningboliu commented on issue #12117: A question about AdaptiveLoadBalance
Posted by "ningboliu (via GitHub)" <gi...@apache.org>.
ningboliu commented on issue #12117:
URL: https://github.com/apache/dubbo/issues/12117#issuecomment-1516457823
Because the bound of pos2 is ( length - 1 ), in order to ensure the balance as much as possible, it should add 1 if pos2 is greater than or equal to pos1 , otherwise it will never get the last invoker. This is an alternative to
`while ( pos1 != (pos2 = ThreadLocalRandom.current().nextInt( length - 1))) {
break;
}`
, and the performance is generally better
I don't know if I made it clearly
@AlbumenJ @MangerLe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] MangerLe commented on issue #12117: A question about AdaptiveLoadBalance
Posted by "MangerLe (via GitHub)" <gi...@apache.org>.
MangerLe commented on issue #12117:
URL: https://github.com/apache/dubbo/issues/12117#issuecomment-1520162084
I Konw, thanks for your reply @ningboliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] MangerLe closed issue #12117: A question about AdaptiveLoadBalance
Posted by "MangerLe (via GitHub)" <gi...@apache.org>.
MangerLe closed issue #12117: A question about AdaptiveLoadBalance
URL: https://github.com/apache/dubbo/issues/12117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org