You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by GitBox <gi...@apache.org> on 2020/01/11 07:20:25 UTC
[GitHub] [directory-scimple] ccrvincent opened a new pull request #23:
SCIMple 84
ccrvincent opened a new pull request #23: SCIMple 84
URL: https://github.com/apache/directory-scimple/pull/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] ccrvincent commented on a change in pull
request #23: SCIMple 84
Posted by GitBox <gi...@apache.org>.
ccrvincent commented on a change in pull request #23: SCIMple 84
URL: https://github.com/apache/directory-scimple/pull/23#discussion_r365505802
##########
File path: pom.xml
##########
@@ -184,7 +184,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
- <version>5.2.0</version>
+ <version>5.5.0</version>
Review comment:
5.2.0 was causing a `java.lang.NoClassDefFoundError: org/junit/platform/commons/PreconditionViolationException` when executing tests via Eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] ussmith merged pull request #23: SCIMple-84 -
Accept and provide application/json content type in addition to
application/scim+json
Posted by GitBox <gi...@apache.org>.
ussmith merged pull request #23: SCIMple-84 - Accept and provide application/json content type in addition to application/scim+json
URL: https://github.com/apache/directory-scimple/pull/23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] ccrvincent commented on a change in pull
request #23: SCIMple 84
Posted by GitBox <gi...@apache.org>.
ccrvincent commented on a change in pull request #23: SCIMple 84
URL: https://github.com/apache/directory-scimple/pull/23#discussion_r365505802
##########
File path: pom.xml
##########
@@ -184,7 +184,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
- <version>5.2.0</version>
+ <version>5.5.0</version>
Review comment:
5.2.0 was causing a `java.lang.NoClassDefFoundError: org/junit/platform/commons/PreconditionViolationException` when executing tests via Eclipse.
Going to a newer version and importing the `junit-jupiter` artifact instead of the individual components corrected the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] ccrvincent commented on a change in pull
request #23: SCIMple 84
Posted by GitBox <gi...@apache.org>.
ccrvincent commented on a change in pull request #23: SCIMple 84
URL: https://github.com/apache/directory-scimple/pull/23#discussion_r365505859
##########
File path: scim-client/src/test/java/org/apache/directory/scim/client/filter/FilterBuilderGreaterTest.java
##########
@@ -62,99 +62,99 @@
public void testGreaterThanT_Int(Integer arg) throws UnsupportedEncodingException, FilterParseException {
String encoded = FilterClient.builder().greaterThan("dog.weight", arg).toString();
- Filter filter = new Filter(decode(encoded));
+ new Filter(decode(encoded));
Review comment:
These were all "Unused Local" warnings. As they are in test classes and exceptions will still get thrown, I have removed the assignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] ccrvincent commented on a change in pull
request #23: SCIMple 84
Posted by GitBox <gi...@apache.org>.
ccrvincent commented on a change in pull request #23: SCIMple 84
URL: https://github.com/apache/directory-scimple/pull/23#discussion_r365506019
##########
File path: scim-spec/scim-spec-schema/src/test/java/org/apache/directory/scim/spec/schema/SchemaTest.java
##########
@@ -71,7 +71,6 @@ public void setUp() {
"schemas/urn:ietf:params:scim:schemas:core:2.0:ServiceProviderConfig.json",
"schemas/urn:ietf:params:scim:schemas:extension:enterprise:2.0:User.json"
})
- @Disabled
Review comment:
As the commit message says, the filenames for the schemas are not Windows friendly, so this test was failing.
I cannot even rename them without using a different OS. I'll file a new low-priority issue, since I'm not sure what the maintainers would want to do with them...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-scimple] ccrvincent commented on a change in pull
request #23: SCIMple 84
Posted by GitBox <gi...@apache.org>.
ccrvincent commented on a change in pull request #23: SCIMple 84
URL: https://github.com/apache/directory-scimple/pull/23#discussion_r365505932
##########
File path: scim-server/scim-server-common/src/test/java/org/apache/directory/scim/server/provider/UpdateRequestTest.java
##########
@@ -27,23 +33,7 @@
import javax.enterprise.inject.Instance;
-import jdk.nashorn.internal.ir.annotations.Ignore;
Review comment:
This was not the correct `@Ignore` annotation for unit tests and caused a "Not API" warning. JUnit 5 moved to `@Disabled`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org