You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/27 01:02:47 UTC

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2508: net/osdp: Use internal data structures and remove dynamic memory allocations

apache-mynewt-bot removed a comment on pull request #2508:
URL: https://github.com/apache/mynewt-core/pull/2508#issuecomment-786971254


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### net/osdp/src/osdp_utils.c
   <details>
   
   ```diff
   @@ -111,9 +111,9 @@
        uint8_t i = 0, len = U16_STR_SZ - 1;
    
        /**
   -    Start filling characters from the end of the buffer,
   -    after accounting for null terminator
   -    */
   +       Start filling characters from the end of the buffer,
   +       after accounting for null terminator
   +     */
        while (num > 0) {
            str[len - 1 - i] = (num % 10) + '0';
            num /= 10;
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org