You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/09 07:29:44 UTC

[GitHub] nzomkxia commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type

nzomkxia commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type
URL: https://github.com/apache/incubator-dubbo/pull/1456#discussion_r180007828
 
 

 ##########
 File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/extension/SpringExtensionFactory.java
 ##########
 @@ -47,6 +52,24 @@ public static void removeApplicationContext(ApplicationContext context) {
                 }
             }
         }
+
+        if (logger.isDebugEnabled()) {
+            logger.debug("No spring extension(bean) named:" + name + ", type:" + type.getName() + " found. Will try to get bean by type only.");
+        }
+
+        for (ApplicationContext context : contexts) {
+            try {
+                return context.getBean(type);
 
 Review comment:
   whether the getBean() returns null or not, this line will end the function progress, is it the real purpose?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services