[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7584: Add check on host's status while deleting config drive on host cache

["rohityadavcloud (via GitHub)" <gi...@apache.org>]

rohityadavcloud commented on code in PR #7584:
URL: https://github.com/apache/cloudstack/pull/7584#discussion_r1214154974


##########
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java:
##########
@@ -573,6 +575,10 @@ private boolean deleteConfigDriveIsoOnHostCache(final VirtualMachine vm, final L
             LOG.warn(String.format("Host %s appears to be unavailable, skipping deletion of config-drive ISO on host cache", hostId));
             return false;
         }
+        if (!Arrays.asList(Status.Up, Status.Connecting).contains(hostVO.getStatus())) {
+            LOG.warn(String.format("Host status %s is not Up or Connecting, skipping deletion of config-drive ISO on host cache", hostId));

Review Comment:
   @weizhouapache @vishesh92 Would `connecting` be included, asking as what if the host isn't up to take the command?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org