You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/07/12 03:14:18 UTC

Re: Review Request 12202: SQOOP-1115 Sqoop2: Integration: Provide helper methods for synchronous job submission

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12202/#review23045
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On June 30, 2013, 6:54 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12202/
> -----------------------------------------------------------
> 
> (Updated June 30, 2013, 6:54 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1115
>     https://issues.apache.org/jira/browse/SQOOP-1115
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've abstracted the same copy&pasted code into helper method that will submit the job in synchronous mode.
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 6aeadd4e54e47e5644270b15813b2d9c4cedc059 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java fbf46e997c73ef3282d62820a50c9b6dc303020c 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java 639d9ad1a37fa6fd577adc2db36ea7b4d63697a2 
> 
> Diff: https://reviews.apache.org/r/12202/diff/
> 
> 
> Testing
> -------
> 
> Both unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>