You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/09/11 01:00:07 UTC

[jira] [Created] (HADOOP-8783) Improve RPC.Server

Daryn Sharp created HADOOP-8783:
-----------------------------------

             Summary: Improve RPC.Server
                 Key: HADOOP-8783
                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
             Project: Hadoop Common
          Issue Type: Sub-task
          Components: ipc, security
    Affects Versions: 2.0.0-alpha, 3.0.0
            Reporter: Daryn Sharp
            Assignee: Daryn Sharp




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468567#comment-13468567 ] 

Hudson commented on HADOOP-8783:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2805 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2805/])
    HADOOP-8783. Improve RPC.Server's digest auth (daryn) (Revision 1393483)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393483
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453116#comment-13453116 ] 

Daryn Sharp commented on HADOOP-8783:
-------------------------------------

Yes, after the client changes, all combinations of secure/insecure client & server and the resulting auth can be easily tested.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469386#comment-13469386 ] 

Hudson commented on HADOOP-8783:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1216 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1216/])
    HADOOP-8783. Improve RPC.Server's digest auth (daryn) (Revision 1393483)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393483
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464884#comment-13464884 ] 

Daryn Sharp commented on HADOOP-8783:
-------------------------------------

I'd like guidance on where I should integrate this patch.  We're considering it for 23, so that would seem to imply it has to be branch-2.  Owen thinks we should consider it for branch-1 as well.  My suggestion would be to go into trunk and branch-2, and once all the umbrella changes are in, we can consider 23 and branch-1.  Thoughts?
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466929#comment-13466929 ] 

Eli Collins commented on HADOOP-8783:
-------------------------------------

+1 to branch-2
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8783:
--------------------------------

    Attachment: HADOOP-8783.patch

Removing hdfs change accidentally included in patch.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8783:
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-alpha
                   3.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Will use umbrella jira to later track integration into 23.x and possibly 1.x
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464891#comment-13464891 ] 

Eli Collins commented on HADOOP-8783:
-------------------------------------

What's the impact?  Looks like HADOOP-8779 is slated for branch-2 so I was assuming all the subtasks would go in branch-2 as well.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8783:
--------------------------------

    Attachment: HADOOP-8783.patch
    
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468588#comment-13468588 ] 

Hudson commented on HADOOP-8783:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2828 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2828/])
    HADOOP-8783. Improve RPC.Server's digest auth (daryn) (Revision 1393483)

     Result = FAILURE
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393483
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469344#comment-13469344 ] 

Hudson commented on HADOOP-8783:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1185 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1185/])
    HADOOP-8783. Improve RPC.Server's digest auth (daryn) (Revision 1393483)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393483
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464859#comment-13464859 ] 

Owen O'Malley commented on HADOOP-8783:
---------------------------------------

Actually, since java doesn't complain if the cases aren't covered, just commit your current patch.

                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8783:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452646#comment-13452646 ] 

Hadoop QA commented on HADOOP-8783:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544553/HADOOP-8783.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
                  org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
                  org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
                  org.apache.hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
                  org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
                  org.apache.hadoop.hdfs.server.namenode.TestEditLog
                  org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
                  org.apache.hadoop.hdfs.server.namenode.TestEditLogRace
                  org.apache.hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional
                  org.apache.hadoop.hdfs.server.namenode.TestNameNodeJspHelper
                  org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
                  org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
                  org.apache.hadoop.hdfs.TestDFSUpgrade

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1432//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1432//console

This message is automatically generated.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453093#comment-13453093 ] 

Kihwal Lee commented on HADOOP-8783:
------------------------------------

+1 (non-binding) Looks good to me. I hope better testing will be added with the client-side changes.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468569#comment-13468569 ] 

Hudson commented on HADOOP-8783:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2867 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2867/])
    HADOOP-8783. Improve RPC.Server's digest auth (daryn) (Revision 1393483)

     Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393483
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8783:
--------------------------------

    Description: RPC.Server should always allow digest auth (tokens) if a secret manager if present.
        Summary: Improve RPC.Server's digest auth  (was: Improve RPC.Server)
    
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465613#comment-13465613 ] 

Daryn Sharp commented on HADOOP-8783:
-------------------------------------

I guess this discussion is really about the target releases for HADOOP-8779.  Overall, the parent jira will make the "security enabled" code paths always be activated.  We know these work, so having tokens always enabled reduces code paths, increases code coverage, and enables thorough testing of tokens via pre-commit tests, etc.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464833#comment-13464833 ] 

Owen O'Malley commented on HADOOP-8783:
---------------------------------------

+1 lgtm

One minor nit is that I'd replace the default case with KERBEROS so that if someone adds a new authentication mechanism that this code would stop compiling rather than do the wrong thing.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8783) Improve RPC.Server's digest auth

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453026#comment-13453026 ] 

Hadoop QA commented on HADOOP-8783:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544639/HADOOP-8783.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1437//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1437//console

This message is automatically generated.
                
> Improve RPC.Server's digest auth
> --------------------------------
>
>                 Key: HADOOP-8783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8783
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc, security
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8783.patch, HADOOP-8783.patch
>
>
> RPC.Server should always allow digest auth (tokens) if a secret manager if present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira