Re: [PR] KAFKA-14585: Move StorageTool to tools [kafka]

["fvaleri (via GitHub)" <gi...@apache.org>]

fvaleri commented on PR #14847:
URL: https://github.com/apache/kafka/pull/14847#issuecomment-2068086501

   @showuon @mimaison I think this is now ready for review.
   
   I think now changes are well isolated. There is no code refactoring or Kafka configuration changes, so comparison with the original code should be straightforward. I'm using `LogConfig` to get all required configurations. Most keys are taken from the configuration objects migrated from `KafkaConfig`. I only miss 3 of them, that I'm defining as constants in `StorageTool`, and will be removed as soon as they are migrated.
   
   I tried all commands and options, comparing the output with the old implementation. I also ran a local 3-nodes Kafka cluster in KRaft mode. Finally, I ran all unit and integration tests.
   
   Please have a look. Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org