You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2017/06/25 02:06:44 UTC
[22/47] lucene-solr:feature/autoscaling: SOLR-10939: update
@SuppressPointFields on TestJoin to note why points are suppressed
SOLR-10939: update @SuppressPointFields on TestJoin to note why points are suppressed
Also update the annotation on TestCloudJSONFacetJoinDomain since SOLR-9989 is resolved but the join problems
still prevent that test from passing with points enabled
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8d92e08c
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/8d92e08c
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/8d92e08c
Branch: refs/heads/feature/autoscaling
Commit: 8d92e08c9c19f478b944ac2d3d4735fc9bb921b0
Parents: ae01113
Author: Chris Hostetter <ho...@apache.org>
Authored: Thu Jun 22 16:05:39 2017 -0700
Committer: Chris Hostetter <ho...@apache.org>
Committed: Thu Jun 22 16:06:05 2017 -0700
----------------------------------------------------------------------
solr/core/src/test/org/apache/solr/TestJoin.java | 2 +-
.../org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8d92e08c/solr/core/src/test/org/apache/solr/TestJoin.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/TestJoin.java b/solr/core/src/test/org/apache/solr/TestJoin.java
index f4b2cf5..0b99b11 100644
--- a/solr/core/src/test/org/apache/solr/TestJoin.java
+++ b/solr/core/src/test/org/apache/solr/TestJoin.java
@@ -37,7 +37,7 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
-@SuppressPointFields
+@SuppressPointFields(bugUrl="https://issues.apache.org/jira/browse/SOLR-10939")
public class TestJoin extends SolrTestCaseJ4 {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8d92e08c/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java b/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java
index afdbb7e..1acf92e 100644
--- a/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java
+++ b/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java
@@ -60,7 +60,7 @@ import org.slf4j.LoggerFactory;
*
* @see TestCloudPivotFacet
*/
-@SuppressPointFields(bugUrl="https://issues.apache.org/jira/browse/SOLR-9989")
+@SuppressPointFields(bugUrl="https://issues.apache.org/jira/browse/SOLR-10939")
public class TestCloudJSONFacetJoinDomain extends SolrCloudTestCase {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
@@ -82,6 +82,10 @@ public class TestCloudJSONFacetJoinDomain extends SolrCloudTestCase {
/** One client per node */
private static ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
+ public TestCloudJSONFacetJoinDomain() {
+ // we need DVs on point fields to compute stats & facets
+ if (Boolean.getBoolean(NUMERIC_POINTS_SYSPROP)) System.setProperty(NUMERIC_DOCVALUES_SYSPROP,"true");
+ }
@BeforeClass
private static void createMiniSolrCloudCluster() throws Exception {