You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2017/08/24 15:23:07 UTC

[GitHub] spark pull request #19039: [SPARK-21829][CORE] Enable config to permanently ...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19039#discussion_r135046165
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
    @@ -94,6 +94,22 @@ private[scheduler] class BlacklistTracker (
       val nodeToBlacklistedExecs = new HashMap[String, HashSet[String]]()
     
       /**
    +   * Blacklists permanently the nodes listed in spark.blacklist.alwaysBlacklistedNodes
    +   * The blacklist timeout is set to a large value, effectively never expiring.
    +   */
    +  private val permanentlyBlacklistedNodes: Seq[String] =
    +    conf.get("spark.blacklist.alwaysBlacklistedNodes", "").split(',').map(_.trim).filter(_ != "")
    --- End diff --
    
    The configuartion should goes to `internal/config`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org