You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/07 14:03:36 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3671: binfmt/elf: Don't close filfd in the fail path
xiaoxiang781216 opened a new pull request #3671:
URL: https://github.com/apache/incubator-nuttx/pull/3671
## Summary
to avoid close the same handle twice because
the caller also call elf_uninit in this case
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3671: binfmt/elf: Don't close filfd in the fail path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3671:
URL: https://github.com/apache/incubator-nuttx/pull/3671#issuecomment-834468558
> Hi @xiaoxiang781216 is elf_init() used in some place? I didn't see some sample code using it. It should be nice to some testing for it.
elf_init is only called by elf_loadbinary. The problem is made by the recent PR:
https://github.com/apache/incubator-nuttx/pull/3670/files#diff-cd1bce68fe9895ea07cd600ebad4d73e101508e748ab13ffc8c6866f81b190afL218-L224
#3670 fix some memory leak, but generate the double free issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #3671: binfmt/elf: Don't close filfd in the fail path
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #3671:
URL: https://github.com/apache/incubator-nuttx/pull/3671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3671: binfmt/elf: Don't close filfd in the fail path
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3671:
URL: https://github.com/apache/incubator-nuttx/pull/3671#issuecomment-834468558
@acassis the problem is made by the recent PR:
https://github.com/apache/incubator-nuttx/pull/3670/files#diff-cd1bce68fe9895ea07cd600ebad4d73e101508e748ab13ffc8c6866f81b190afL218-L224
#3670 fix some memory leak, but generate the double free issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3671: binfmt/elf: Don't close filfd in the fail path
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3671:
URL: https://github.com/apache/incubator-nuttx/pull/3671#issuecomment-834459551
Hi @xiaoxiang781216 is elf_init() used in some place? I didn't see some sample code using it. It should be nice to some testing for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org