[GitHub] [shardingsphere] TeslaCN commented on issue #8570: shardingsphere-jdbc-governance incompatible with HikariCP >= 3.4.3

[GitBox <gi...@apache.org>]

TeslaCN commented on issue #8570:
URL: https://github.com/apache/shardingsphere/issues/8570#issuecomment-743027246


   Hi @tristaZero ,
   
   My idea is ignoring property with null value when converting a `DataSource` to `DataSourceConfiguration`. I don't know if there are any other effects.
   
   Before: 
   ```yaml
   dataSources:
     dataSource:
       dataSourceClassName: com.zaxxer.hikari.HikariDataSource
       props:
         password: postgres
         transactionIsolation: null
         connectionTestQuery: null
         driverClassName: org.postgresql.Driver
         jdbcUrl: jdbc:postgresql://pg.local.wwj.icu:5432/elasticjob
         schema: null
         dataSourceClassName: null
         connectionTimeout: 30000
         idleTimeout: 600000
         exceptionOverrideClassName: null
         username: postgres
         dataSourceJNDI: null
         initializationFailTimeout: 1
         minimumIdle: 10
         maxLifetime: 1800000
         maximumPoolSize: 10
         validationTimeout: 5000
         leakDetectionThreshold: 0
         connectionInitSql: null
         poolName: HikariPool-1
         catalog: null
   ```
   
   After: 
   ```yaml
   dataSources:
     dataSource:
       dataSourceClassName: com.zaxxer.hikari.HikariDataSource
       props:
         password: postgres
         driverClassName: org.postgresql.Driver
         jdbcUrl: jdbc:postgresql://pg.local.wwj.icu:5432/elasticjob
         connectionTimeout: 30000
         idleTimeout: 600000
         username: postgres
         initializationFailTimeout: 1
         minimumIdle: 10
         maxLifetime: 1800000
         maximumPoolSize: 10
         validationTimeout: 5000
         leakDetectionThreshold: 0
         poolName: HikariPool-1
   ```
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org