You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/13 12:46:58 UTC

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

codecov-commenter commented on pull request #1033:
URL: https://github.com/apache/hadoop-ozone/pull/1033#issuecomment-643618997


   # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=h1) Report
   > Merging [#1033](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/96f07d5c27ba8f2ab9d77df25e10d4cb94489e5f&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `28.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/graphs/tree.svg?width=650&height=150&src=pr&token=5YeeptJMby)](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1033      +/-   ##
   ============================================
   - Coverage     69.36%   69.29%   -0.07%     
   - Complexity     9103     9112       +9     
   ============================================
     Files           961      963       +2     
     Lines         48127    48244     +117     
     Branches       4676     4687      +11     
   ============================================
   + Hits          33381    33430      +49     
   - Misses        12530    12594      +64     
   - Partials       2216     2220       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ne/container/common/statemachine/StateContext.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9TdGF0ZUNvbnRleHQuamF2YQ==) | `85.02% <ø> (-0.09%)` | `52.00 <0.00> (-1.00)` | |
   | [...p/ozone/protocol/commands/UnRegisteredCommand.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9wcm90b2NvbC9jb21tYW5kcy9VblJlZ2lzdGVyZWRDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ntainerDatanodeProtocolClientSideTranslatorPB.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9wcm90b2NvbFBCL1N0b3JhZ2VDb250YWluZXJEYXRhbm9kZVByb3RvY29sQ2xpZW50U2lkZVRyYW5zbGF0b3JQQi5qYXZh) | `85.71% <0.00%> (-11.06%)` | `10.00 <0.00> (ø)` | |
   | [...rg/apache/hadoop/hdds/scm/node/SCMNodeManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvU0NNTm9kZU1hbmFnZXIuamF2YQ==) | `84.29% <0.00%> (-2.89%)` | `55.00 <0.00> (ø)` | |
   | [...oop/hdds/scm/server/SCMDatanodeProtocolServer.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3NlcnZlci9TQ01EYXRhbm9kZVByb3RvY29sU2VydmVyLmphdmE=) | `67.97% <0.00%> (-7.18%)` | `24.00 <0.00> (ø)` | |
   | [.../apache/hadoop/hdds/scm/node/NodeStateManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvTm9kZVN0YXRlTWFuYWdlci5qYXZh) | `73.37% <33.33%> (-1.63%)` | `42.00 <0.00> (ø)` | |
   | [...common/states/endpoint/UnRegisterEndpointTask.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlcy9lbmRwb2ludC9VblJlZ2lzdGVyRW5kcG9pbnRUYXNrLmphdmE=) | `44.23% <44.23%> (ø)` | `4.00 <4.00> (?)` | |
   | [.../java/org/apache/hadoop/ozone/audit/SCMAction.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvYXVkaXQvU0NNQWN0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | [...r/common/states/datanode/RunningDatanodeState.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlcy9kYXRhbm9kZS9SdW5uaW5nRGF0YW5vZGVTdGF0ZS5qYXZh) | `78.57% <100.00%> (-3.25%)` | `17.00 <0.00> (-2.00)` | |
   | [...otocol/commands/RetriableDatanodeEventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sL2NvbW1hbmRzL1JldHJpYWJsZURhdGFub2RlRXZlbnRXYXRjaGVyLmphdmE=) | `55.55% <0.00%> (-44.45%)` | `3.00% <0.00%> (-1.00%)` | |
   | ... and [17 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1033/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=footer). Last update [96f07d5...8b89fad](https://codecov.io/gh/apache/hadoop-ozone/pull/1033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org