[GitHub] [solr] cpoerschke commented on a change in pull request #35: SOLR-15273: Distributed Group Query supports rename unique key field name

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #35:
URL: https://github.com/apache/solr/pull/35#discussion_r599576273



##########
File path: solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/StoredFieldsShardResponseProcessor.java
##########
@@ -38,6 +38,10 @@ public void process(ResponseBuilder rb, ShardRequest shardRequest) {
     SolrDocumentList docs = (SolrDocumentList)srsp.getSolrResponse().getResponse().get("response");
     String uniqueIdFieldName = rb.req.getSchema().getUniqueKeyField().getName();
 
+    if (rb.rsp.getReturnFields().getFieldRenames().get(uniqueIdFieldName) != null) {
+      // if id was renamed we need to use the new name
+      uniqueIdFieldName = rb.rsp.getReturnFields().getFieldRenames().get(uniqueIdFieldName);
+    }

Review comment:
       observation: for non-grouped queries the query component already has similar logic e.g. https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.8.1/solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java#L1187-L1190




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org