[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas

[GitBox <gi...@apache.org>]

siddharthteotia edited a comment on issue #4446: Add support in the rebalancer for the user to provide minimum number of serving replicas
URL: https://github.com/apache/incubator-pinot/pull/4446#issuecomment-517390893
 
 
   Thanks @snleee , @mcvsubbu for reviewing and approving the changes.
   
   Some follow up items I will address in upcoming PRs:
   
   1. Revisit the logic where we fetch the ideal state again and recompute the target. There is potential room for optimization here  -- fetch the ideal state again and recompute target only if we previously failed to write in ZK due to version mismatch.
   
   2. For the rest api based access that runs rebalance in async mode, we need to show which controller is responding to the rebalance request.
   
   3. Re-use the recently merged controller test apis in the integration test to start/stop fake servers.
   
   4. See if logging can be improved/changed to ensure info level messages are giving enough information.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org